Attachment 79269 Details for Bug 52623 – Patch.

[patch] Patch.

patch (text/plain), 2.26 KB, created by Pavel Podivilov on 2011-01-18 05:38:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Pavel Podivilov

Created: 2011-01-18 05:38:00 PST

Size: 2.26 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 580346f..a0a4b8e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2011-01-18  Pavel Podivilov  <podivilov@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
>+        https://bugs.webkit.org/show_bug.cgi?id=52623
>+
>+        * inspector/front-end/ConsoleView.js:
>+        (WebInspector.ConsoleMessage):
>+        (WebInspector.ConsoleMessage.prototype._formatMessage):
>+
> 2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
> 
>         Reviewed by Yury Semikhatsky.
>diff --git a/Source/WebCore/inspector/front-end/ConsoleView.js b/Source/WebCore/inspector/front-end/ConsoleView.js
>index a40030e..84d1113 100644
>--- a/Source/WebCore/inspector/front-end/ConsoleView.js
>+++ b/Source/WebCore/inspector/front-end/ConsoleView.js
>@@ -681,6 +681,13 @@ WebInspector.ConsoleMessage = function(source, type, level, line, url, repeatCou
>     this._parameters = parameters;
>     this._stackTrace = stackTrace;
>     this._requestId = requestId;
>+
>+    if (stackTrace && stackTrace.length) {
>+        var topCallFrame = stackTrace[0];
>+        this.url = topCallFrame.scriptName;
>+        this.line = topCallFrame.lineNumber;
>+    }
>+
>     this._formatMessage();
> }
> 
>@@ -737,17 +744,8 @@ WebInspector.ConsoleMessage.prototype = {
>         this._formattedMessage = document.createElement("span");
>         this._formattedMessage.className = "console-message-text source-code";
> 
>-        if (stackTrace && stackTrace.length) {
>-            var topCallFrame = stackTrace[0];
>-            var sourceName = topCallFrame.scriptName;
>-            var sourceLine = topCallFrame.lineNumber;
>-        } else {
>-            var sourceName = this.url;
>-            var sourceLine = this.line;
>-        }
>-
>-        if (sourceName && sourceName !== "undefined") {
>-            var urlElement = WebInspector.linkifyResourceAsNode(sourceName, "scripts", sourceLine, "console-message-url");
>+        if (this.url && this.url !== "undefined") {
>+            var urlElement = WebInspector.linkifyResourceAsNode(this.url, "scripts", this.line, "console-message-url");
>             this._formattedMessage.appendChild(urlElement);
>         }
>

Flags:

yurys: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 52623: 79269