Attachment 78353 Details for Bug 52132 – Use a parsed URL in WKURLRequestCreateWithWKURL

[patch] Use a parsed URL in WKURLRequestCreateWithWKURL

bug-52132-20110109110429.patch (text/plain), 2.50 KB, created by mitz on 2011-01-09 11:04:30 PST

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2011-01-09 11:04:30 PST

Size: 2.50 KB

patch

obsolete

>Index: WebKit2/ChangeLog
>===================================================================
>--- WebKit2/ChangeLog	(revision 75352)
>+++ WebKit2/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2011-01-09  Dan Bernstein  <mitz@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Assertion failure in KURL::KURL when calling WKURLRequestCreateWithWKURL with a non-parsed URL
>+        https://bugs.webkit.org/show_bug.cgi?id=52132
>+
>+        * Shared/API/c/WKURLRequest.cpp:
>+        (WKURLRequestCreateWithWKURL): Parse the URL.
>+        * Shared/WebString.h: Fixed a comment.
>+        * Shared/WebURL.h: Ditto.
>+
> 2011-01-09  Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
> 
>         Reviewed by Martin Robinson.
>Index: WebKit2/Shared/WebString.h
>===================================================================
>--- WebKit2/Shared/WebString.h	(revision 75343)
>+++ WebKit2/Shared/WebString.h	(working copy)
>@@ -34,7 +34,7 @@
> 
> namespace WebKit {
> 
>-// WebString - An string array type suitable for vending to an API.
>+// WebString - A string type suitable for vending to an API.
> 
> class WebString : public APIObject {
> public:
>Index: WebKit2/Shared/WebURL.h
>===================================================================
>--- WebKit2/Shared/WebURL.h	(revision 75343)
>+++ WebKit2/Shared/WebURL.h	(working copy)
>@@ -32,7 +32,7 @@
> 
> namespace WebKit {
> 
>-// WebURL - An string array type suitable for vending to an API.
>+// WebURL - A URL type suitable for vending to an API.
> 
> class WebURL : public APIObject {
> public:
>Index: WebKit2/Shared/API/c/WKURLRequest.cpp
>===================================================================
>--- WebKit2/Shared/API/c/WKURLRequest.cpp	(revision 75343)
>+++ WebKit2/Shared/API/c/WKURLRequest.cpp	(working copy)
>@@ -1,5 +1,5 @@
> /*
>- * Copyright (C) 2010 Apple Inc. All rights reserved.
>+ * Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>@@ -27,7 +27,9 @@
> 
> #include "WKAPICast.h"
> #include "WebURLRequest.h"
>+#include <WebCore/KURL.h>
> 
>+using namespace WebCore;
> using namespace WebKit;
> 
> WKTypeID WKURLRequestGetTypeID()
>@@ -37,5 +39,5 @@ WKTypeID WKURLRequestGetTypeID()
> 
> WKURLRequestRef WKURLRequestCreateWithWKURL(WKURLRef url)
> {
>-    return toAPI(WebURLRequest::create(toImpl(url)->string()).leakRef());
>+    return toAPI(WebURLRequest::create(KURL(KURL(), toImpl(url)->string())).leakRef());
> }

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 52132: 78353