Attachment 77856 Details for Bug 51858 – Remove m_row and m_col

[patch] Remove m_row and m_col

bug-51858-20110103175829.patch (text/plain), 1.87 KB, created by mitz on 2011-01-03 17:58:30 PST

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2011-01-03 17:58:30 PST

Size: 1.87 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 74951)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2011-01-03  Dan Bernstein  <mitz@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Shrink HTMLTableCellElement
>+        https://bugs.webkit.org/show_bug.cgi?id=51858
>+
>+        * html/HTMLTableCellElement.cpp:
>+        (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
>+        m_col.
>+        * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
>+
> 2011-01-03  Darin Adler  <darin@apple.com>
> 
>         Reviewed by Brady Eidson.
>Index: WebCore/html/HTMLTableCellElement.cpp
>===================================================================
>--- WebCore/html/HTMLTableCellElement.cpp	(revision 74949)
>+++ WebCore/html/HTMLTableCellElement.cpp	(working copy)
>@@ -44,8 +44,6 @@ using namespace HTMLNames;
> 
> inline HTMLTableCellElement::HTMLTableCellElement(const QualifiedName& tagName, Document* document)
>     : HTMLTablePartElement(tagName, document)
>-    , m_row(-1)
>-    , m_col(-1)
>     , m_rowSpan(1)
>     , m_colSpan(1)
> {
>Index: WebCore/html/HTMLTableCellElement.h
>===================================================================
>--- WebCore/html/HTMLTableCellElement.h	(revision 74949)
>+++ WebCore/html/HTMLTableCellElement.h	(working copy)
>@@ -36,11 +36,6 @@ public:
> 
>     int cellIndex() const;
> 
>-    int col() const { return m_col; }
>-    void setCol(int col) { m_col = col; }
>-    int row() const { return m_row; }
>-    void setRow(int row) { m_row = row; }
>-
>     int colSpan() const { return m_colSpan; }
>     int rowSpan() const { return m_rowSpan; }
> 
>@@ -69,8 +64,6 @@ private:
> 
>     virtual void addSubresourceAttributeURLs(ListHashSet<KURL>&) const;
> 
>-    int m_row;
>-    int m_col;
>     int m_rowSpan;
>     int m_colSpan;
> };

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 51858: 77856