Attachment 71479 Details for Bug 48090 – Proposed Change

[patch] Proposed Change

0001-Remove-stale-stubs-that-are-not-longer-part-of-Inspe.patch (text/plain), 4.04 KB, created by Timothy Hatcher on 2010-10-21 13:24:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2010-10-21 13:24:42 PDT

Size: 4.04 KB

patch

obsolete

>From 00b0c9c6def99371ee4fdf7bbf00f3dde695fdb7 Mon Sep 17 00:00:00 2001
>From: Timothy Hatcher <timothy@apple.com>
>Date: Thu, 21 Oct 2010 13:23:48 -0700
>Subject: [PATCH] Remove stale stubs that are not longer part of InspectorClient.
>
>https://bugs.webkit.org/show_bug.cgi?id=48090
>
>Reviewed by NOBODY (OOPS!).
>
>* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
>* WebProcess/WebCoreSupport/WebInspectorClient.h:
>---
> WebKit2/ChangeLog                                  |   11 ++++
> .../WebCoreSupport/WebInspectorClient.cpp          |   54 --------------------
> .../WebProcess/WebCoreSupport/WebInspectorClient.h |   20 +-------
> 3 files changed, 12 insertions(+), 73 deletions(-)
>
>diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
>index b66f444..0f5ab17 100644
>--- a/WebKit2/ChangeLog
>+++ b/WebKit2/ChangeLog
>@@ -1,3 +1,14 @@
>+2010-10-21  Timothy Hatcher  <timothy@apple.com>
>+
>+        Remove stale stubs that are not longer part of InspectorClient.
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=48090
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
>+        * WebProcess/WebCoreSupport/WebInspectorClient.h:
>+
> 2010-10-20  Anders Carlsson  <andersca@apple.com>
> 
>         Fix clang++ build.
>diff --git a/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp b/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
>index c2f9512..e93b313 100644
>--- a/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
>+++ b/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp
>@@ -42,49 +42,6 @@ void WebInspectorClient::openInspectorFrontend(InspectorController*)
>     notImplemented();
> }
> 
>-Page* WebInspectorClient::createPage()
>-{
>-    notImplemented();
>-    return 0;
>-}
>-
>-String WebInspectorClient::localizedStringsURL()
>-{
>-    notImplemented();
>-    return String();
>-}
>-
>-String WebInspectorClient::hiddenPanels()
>-{
>-    notImplemented();
>-    return String();
>-}
>-
>-void WebInspectorClient::showWindow()
>-{
>-    notImplemented();
>-}
>-
>-void WebInspectorClient::closeWindow()
>-{
>-    notImplemented();
>-}
>-
>-void WebInspectorClient::attachWindow()
>-{
>-    notImplemented();
>-}
>-
>-void WebInspectorClient::detachWindow()
>-{
>-    notImplemented();
>-}
>-
>-void WebInspectorClient::setAttachedWindowHeight(unsigned height)
>-{
>-    notImplemented();
>-}
>-
> void WebInspectorClient::highlight(Node*)
> {
>     notImplemented();
>@@ -95,11 +52,6 @@ void WebInspectorClient::hideHighlight()
>     notImplemented();
> }
> 
>-void WebInspectorClient::inspectedURLChanged(const String& newURL)
>-{
>-    notImplemented();
>-}
>-
> void WebInspectorClient::populateSetting(const String& key, String*)
> {
>     notImplemented();
>@@ -116,10 +68,4 @@ bool WebInspectorClient::sendMessageToFrontend(const String&)
>     return false;
> }
> 
>-
>-void WebInspectorClient::inspectorWindowObjectCleared()
>-{
>-    notImplemented();
>-}
>-
> } // namespace WebKit
>diff --git a/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h b/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h
>index 26cca5f..b9225c3 100644
>--- a/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h
>+++ b/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h
>@@ -41,35 +41,17 @@ public:
>     
> private:
>     virtual void inspectorDestroyed();
>-    
>+
>     virtual void openInspectorFrontend(WebCore::InspectorController*);
> 
>-    virtual WebCore::Page* createPage();
>-    
>-    virtual String localizedStringsURL();
>-    
>-    virtual String hiddenPanels();
>-    
>-    virtual void showWindow();
>-    virtual void closeWindow();
>-    
>-    virtual void attachWindow();
>-    virtual void detachWindow();
>-    
>-    virtual void setAttachedWindowHeight(unsigned height);
>-    
>     virtual void highlight(WebCore::Node*);
>     virtual void hideHighlight();
>-    
>-    virtual void inspectedURLChanged(const String& newURL);
> 
>     virtual void populateSetting(const String& key, String* value);
>     virtual void storeSetting(const String& key, const String& value);
> 
>     virtual bool sendMessageToFrontend(const String&);
> 
>-    virtual void inspectorWindowObjectCleared();
>-    
>     WebPage* m_page;
> };
> 
>-- 
>1.7.0.2
>

Flags:

aroben: review+
timothy: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 48090: 71479