Attachment 68897 Details for Bug 46617 – Just wait for the window to be on screen before modifying it

[patch] Just wait for the window to be on screen before modifying it

46617.patch (text/plain), 1.16 KB, created by Benjamin Poulain on 2010-09-27 04:31:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Poulain

Created: 2010-09-27 04:31:48 PDT

Size: 1.16 KB

patch

obsolete

>diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
>index edc8e24..4e31ccb 100644
>--- a/WebKit/qt/ChangeLog
>+++ b/WebKit/qt/ChangeLog
>@@ -1,3 +1,15 @@
>+2010-09-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [Qt] tst_QWebFrame::popupFocus() randomly fail on MeeGo handset because the focus is not set on the window
>+        https://bugs.webkit.org/show_bug.cgi?id=46617
>+
>+        This patch avoid the race condition by waiting for the window
>+        to be mapped on screen before attempting any actions.
>+
>+        * tests/qwebframe/tst_qwebframe.cpp:
>+
> 2010-09-23  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
> 
>         Reviewed by Kenneth Rohde Christiansen.
>diff --git a/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp b/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
>index bdafa17..6b91635 100644
>--- a/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
>+++ b/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
>@@ -2601,6 +2601,7 @@ void tst_QWebFrame::popupFocus()
>                  "</html>");
>     view.resize(400, 100);
>     view.show();
>+    QTest::qWaitForWindowShown(&view);
>     view.setFocus();
>     QTRY_VERIFY(view.hasFocus());
>

Actions: View | Formatted Diff | Diff

Attachments on bug 46617: 68897