Attachment 67410 Details for Bug 45427 – Patch

[patch] Patch

bug-45427-20100914001030.patch (text/plain), 3.59 KB, created by Ryuan Choi on 2010-09-13 08:10:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryuan Choi

Created: 2010-09-13 08:10:30 PDT

Size: 3.59 KB

patch

obsolete

>Index: WebKit/efl/ChangeLog
>===================================================================
>--- WebKit/efl/ChangeLog	(revision 67387)
>+++ WebKit/efl/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2010-09-13  Ryuan Choi  <ryuan.choi@samsung.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [EFL] Add setting api for enabling encoding detector
>+        https://bugs.webkit.org/show_bug.cgi?id=45427
>+
>+        Add settings api for enabling encoding detector.
>+
>+        * ewk/ewk_view.cpp:
>+        (ewk_view_setting_encoding_detector_set):
>+        (ewk_view_setting_encoding_detector_get):
>+        * ewk/ewk_view.h:
>+
> 2010-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
> 
>         Reviewed by Antonio Gomes.
>Index: WebKit/efl/ewk/ewk_view.cpp
>===================================================================
>--- WebKit/efl/ewk/ewk_view.cpp	(revision 67385)
>+++ WebKit/efl/ewk/ewk_view.cpp	(working copy)
>@@ -105,6 +105,7 @@ struct _Ewk_View_Private_Data {
>         Eina_Bool enable_scripts:1;
>         Eina_Bool enable_plugins:1;
>         Eina_Bool enable_frame_flattening:1;
>+        Eina_Bool encoding_detector:1;
>         Eina_Bool scripts_window_open:1;
>         Eina_Bool resizable_textareas:1;
>         Eina_Bool private_browsing:1;
>@@ -2499,6 +2500,37 @@ Eina_Bool ewk_view_setting_encoding_defa
>     return EINA_TRUE;
> }
> 
>+/**
>+ * Sets the encoding detector.
>+ *
>+ * @param o view object to set if encoding detector is enabled.
>+ * @return @c EINA_TRUE on success and @c EINA_FALSE on failure
>+ */
>+Eina_Bool ewk_view_setting_encoding_detector_set(Evas_Object* o, Eina_Bool enable)
>+{
>+    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
>+    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
>+    enable = !!enable;
>+    if (priv->settings.encoding_detector != enable) {
>+        priv->page_settings->setUsesEncodingDetector(enable);
>+        priv->settings.encoding_detector = enable;
>+    }
>+    return EINA_TRUE;
>+}
>+
>+/**
>+ * Gets if the encoding detector is enabled.
>+ *
>+ * @param o view object to get if encoding detector is enabled.
>+ * @return @c EINA_TRUE if encoding detector is enabled, @c EINA_FALSE if not or on errors.
>+ */
>+Eina_Bool ewk_view_setting_encoding_detector_get(Evas_Object* o)
>+{
>+    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
>+    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
>+    return priv->settings.encoding_detector;
>+}
>+
> const char* ewk_view_setting_cache_directory_get(const Evas_Object* o)
> {
>     EWK_VIEW_SD_GET_OR_RETURN(o, sd, 0);
>@@ -2717,8 +2749,8 @@ Eina_Bool ewk_view_setting_spatial_navig
> /**
>  * Gets if the local storage is enabled.
>  *
>- * @param o view object to set if local storage is enabled.
>- * @return @c EINA_TRUE if local storage is enabled, @c EINA_FALSE if not.
>+ * @param o view object to get if local storage is enabled.
>+ * @return @c EINA_TRUE if local storage is enabled, @c EINA_FALSE if not or on errors.
>  */
> Eina_Bool ewk_view_setting_local_storage_get(Evas_Object* o)
> {
>Index: WebKit/efl/ewk/ewk_view.h
>===================================================================
>--- WebKit/efl/ewk/ewk_view.h	(revision 67385)
>+++ WebKit/efl/ewk/ewk_view.h	(working copy)
>@@ -450,6 +450,9 @@ EAPI Eina_Bool    ewk_view_setting_spati
> EAPI Eina_Bool    ewk_view_setting_local_storage_get(Evas_Object* o);
> EAPI Eina_Bool    ewk_view_setting_local_storage_set(Evas_Object* o, Eina_Bool enable);
> 
>+EAPI Eina_Bool    ewk_view_setting_encoding_detector_get(Evas_Object* o);
>+EAPI Eina_Bool    ewk_view_setting_encoding_detector_set(Evas_Object* o, Eina_Bool enable);
>+
> /* to be used by subclass implementations */
> EAPI Ewk_View_Smart_Data *ewk_view_smart_data_get(const Evas_Object *o);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 45427: 66974 | 67355 | 67359 | 67410 | 67560