Attachment 67323 Details for Bug 43365 – Tested patch for this issue

[patch] Tested patch for this issue

bug-43365-20100911185609.patch (text/plain), 3.47 KB, created by Martin Robinson on 2010-09-11 18:56:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Robinson

Created: 2010-09-11 18:56:11 PDT

Size: 3.47 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 421eaa678769e0c7873df84c81f1315bb2c168c7..9ed8c57f1c5402f9a07678d1356db69289bfd9c7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,5 +1,14 @@
> 2010-09-11  Martin Robinson  <mrobinson@igalia.com>
> 
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [Qt] DOM listeners get wrong keycodes for some keys
>+        https://bugs.webkit.org/show_bug.cgi?id=43365
>+
>+        * platform/qt/Skipped: Unskip tests that are now passing.
>+
>+2010-09-11  Martin Robinson  <mrobinson@igalia.com>
>+
>         Add a platform-specific result after r67281.
> 
>         * platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.
>diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
>index 38c623661548f2e8ff453f9e7680de5c97f9d083..ab189619aee414e1d770acd906037e56b370de6f 100644
>--- a/LayoutTests/platform/qt/Skipped
>+++ b/LayoutTests/platform/qt/Skipped
>@@ -5422,11 +5422,6 @@ fast/events/spatial-navigation/snav-clipped-overflowed-content.html
> # See http://code.google.com/p/chromium/issues/detail?id=19897
> svg/custom/getscreenctm-in-mixed-content2.xhtml
> 
>-# [Qt] DOM listeners get wrong keycodes for some keys
>-# https://bugs.webkit.org/show_bug.cgi?id=43365
>-fast/events/keydown-numpad-keys.html
>-fast/events/special-key-events-in-input-text.html
>-
> # Still working out flakiness issues with the perf tests.
> # https://bugs.webkit.org/show_bug.cgi?id=44199
> perf/
>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>index a1cdf368a516db230c040b70928e38a49539e3e0..e9ae0e43328d77948d24551354df6a51f29de5d6 100644
>--- a/WebCore/ChangeLog
>+++ b/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2010-09-11  Martin Robinson  <mrobinson@igalia.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [Qt] DOM listeners get wrong keycodes for some keys
>+        https://bugs.webkit.org/show_bug.cgi?id=43365
>+
>+        Produce the proper keycodes for the print screen key as well as the
>+        keypad insert and delete keys.
>+
>+        * platform/qt/PlatformKeyboardEventQt.cpp:
>+        (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
>+
> 2010-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
> 
>         Unreviewed.
>diff --git a/WebCore/platform/qt/PlatformKeyboardEventQt.cpp b/WebCore/platform/qt/PlatformKeyboardEventQt.cpp
>index 6dde9c463844290949e3c6e2705d47f97c4db478..d0edb161603e6dc1f0245575d9af03a5311f49c6 100644
>--- a/WebCore/platform/qt/PlatformKeyboardEventQt.cpp
>+++ b/WebCore/platform/qt/PlatformKeyboardEventQt.cpp
>@@ -188,6 +188,10 @@ int windowsKeyCodeForKeyEvent(unsigned int keycode, bool isKeypad)
>             return VK_RIGHT; // (27) RIGHT ARROW key
>         case Qt::Key_Down:
>             return VK_DOWN; // (28) DOWN ARROW key
>+        case Qt::Key_Insert:
>+            return VK_INSERT; // (2D) INS key
>+        case Qt::Key_Delete:
>+            return VK_DELETE; // (2E) DEL key
>         default:
>             return 0;
>         }
>@@ -304,12 +308,9 @@ int windowsKeyCodeForKeyEvent(unsigned int keycode, bool isKeypad)
>     case Qt::Key_Select:
>         return VK_SELECT; // (29) SELECT key
>     case Qt::Key_Print:
>-        return VK_PRINT; // (2A) PRINT key
>+        return VK_SNAPSHOT; // (2A) PRINT key
>     case Qt::Key_Execute:
>         return VK_EXECUTE; // (2B) EXECUTE key
>-        // dunno on this
>-        // case Qt::Key_PrintScreen:
>-        // return VK_SNAPSHOT; // (2C) PRINT SCREEN key
>     case Qt::Key_Insert:
>         return VK_INSERT; // (2D) INS key
>     case Qt::Key_Delete:

Flags:

kling: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 43365: 63233 | 67323