Attachment 53991 Details for Bug 37719 – Implemented as a switch/case per review comment from Darin.

[patch] Implemented as a switch/case per review comment from Darin.

vkbtypefix-against-57695-changelog-switch.txt (text/plain), 1.70 KB, created by Ray on 2010-04-21 14:21:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ray

Created: 2010-04-21 14:21:20 PDT

Size: 1.70 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 58010)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2010-04-21  Ray Rischpater  <Raymond.Rischpater@Nokia.com>
>+
>+        Reviewed by Darin Adler.
>+
>+        In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
>+        HTML5 input types (TELEPHONE, NUMBER, URL, and EMAIL). This
>+        prevents the virtual keyboard from being brought up for these
>+        input types.
>+
>+        Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>
>+
>+        * html/HTMLInputElement.cpp:
>+        (WebCore::HTMLInputElement::shouldUseInputMethod):
>+
> 2010-04-21  Gavin Barraclough  <barraclough@apple.com>
> 
>         Reviewed by NOBODY (Qt build fix).
>Index: WebCore/html/HTMLInputElement.cpp
>===================================================================
>--- WebCore/html/HTMLInputElement.cpp	(revision 57735)
>+++ WebCore/html/HTMLInputElement.cpp	(working copy)
>@@ -734,7 +734,35 @@
> 
> bool HTMLInputElement::shouldUseInputMethod() const
> {
>-    return m_type == TEXT || m_type == SEARCH || m_type == ISINDEX;
>+    switch (inputType()) {
>+    case NUMBER:
>+    case TELEPHONE:
>+    case TEXT:
>+    case EMAIL:
>+    case SEARCH:
>+    case ISINDEX:
>+    case PASSWORD:
>+    case URL:
>+        return true;
>+    case DATE:
>+    case DATETIME:
>+    case DATETIMELOCAL:
>+    case FILE:
>+    case MONTH:
>+    case TIME:
>+    case WEEK:
>+    case CHECKBOX:
>+    case RADIO:
>+    case COLOR:
>+    case BUTTON:
>+    case HIDDEN:
>+    case IMAGE:
>+    case RANGE:
>+    case RESET:
>+    case SUBMIT:
>+        return false;
>+    }
>+    return false;
> }
> 
> void HTMLInputElement::handleFocusEvent()

Actions: View | Formatted Diff | Diff

Attachments on bug 37719: 53563 | 53699 | 53734 | 53830 | 53984 | 53991 | 53993 | 54097