Attachment 52875 Details for Bug 33056 – New patch

[patch] New patch

bug-33056.patch (text/plain), 2.66 KB, created by Patrick R. Gansterer on 2010-04-08 09:37:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick R. Gansterer

Created: 2010-04-08 09:37:06 PDT

Size: 2.66 KB

patch

obsolete

>Index: JavaScriptCore/ChangeLog
>===================================================================
>--- JavaScriptCore/ChangeLog	(revision 57283)
>+++ JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2010-04-08  Patrick Gansterer  <paroga@paroga.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implement NO_RETURN for COMPILER(MSVC).
>+        https://bugs.webkit.org/show_bug.cgi?id=33056 
>+
>+        Added NO_VALUE_RETURN for functions with non-void return type.
>+
>+        * jsc.cpp:
>+        * wtf/AlwaysInline.h:
>+        * wtf/FastMalloc.cpp:
>+
> 2010-04-08  Kwang Yul Seo  <skyul@company100.net>
> 
>         Reviewed by Simon Hausmann.
>Index: JavaScriptCore/jsc.cpp
>===================================================================
>--- JavaScriptCore/jsc.cpp	(revision 57283)
>+++ JavaScriptCore/jsc.cpp	(working copy)
>@@ -79,7 +79,7 @@ static JSValue JSC_HOST_CALL functionRun
> static JSValue JSC_HOST_CALL functionLoad(ExecState*, JSObject*, JSValue, const ArgList&);
> static JSValue JSC_HOST_CALL functionCheckSyntax(ExecState*, JSObject*, JSValue, const ArgList&);
> static JSValue JSC_HOST_CALL functionReadline(ExecState*, JSObject*, JSValue, const ArgList&);
>-static NO_RETURN JSValue JSC_HOST_CALL functionQuit(ExecState*, JSObject*, JSValue, const ArgList&);
>+static NO_VALUE_RETURN JSValue JSC_HOST_CALL functionQuit(ExecState*, JSObject*, JSValue, const ArgList&);
> 
> #if ENABLE(SAMPLING_FLAGS)
> static JSValue JSC_HOST_CALL functionSetSamplingFlags(ExecState*, JSObject*, JSValue, const ArgList&);
>Index: JavaScriptCore/wtf/AlwaysInline.h
>===================================================================
>--- JavaScriptCore/wtf/AlwaysInline.h	(revision 57283)
>+++ JavaScriptCore/wtf/AlwaysInline.h	(working copy)
>@@ -59,9 +59,17 @@
> #ifndef NO_RETURN
> #if COMPILER(GCC)
> #define NO_RETURN __attribute((__noreturn__))
>-#elif COMPILER(RVCT)
>+#elif COMPILER(MSVC) || COMPILER(RVCT)
> #define NO_RETURN __declspec(noreturn)
> #else
> #define NO_RETURN
> #endif
> #endif
>+
>+#ifndef NO_VALUE_RETURN
>+#if !COMPILER(MSVC)
>+#define NO_VALUE_RETURN NO_RETURN
>+#else
>+#define NO_VALUE_RETURN
>+#endif
>+#endif
>Index: JavaScriptCore/wtf/FastMalloc.cpp
>===================================================================
>--- JavaScriptCore/wtf/FastMalloc.cpp	(revision 57283)
>+++ JavaScriptCore/wtf/FastMalloc.cpp	(working copy)
>@@ -1431,7 +1431,7 @@ class TCMalloc_PageHeap {
>   ALWAYS_INLINE bool shouldScavenge() const;
> 
> #if !HAVE(DISPATCH_H)
>-  static NO_RETURN void* runScavengerThread(void*);
>+  static NO_VALUE_RETURN void* runScavengerThread(void*);
>   NO_RETURN void scavengerThread();
> 
>   // Keeps track of whether the background thread is actively scavenging memory every kScavengeDelayInSeconds, or

Flags:

darin: review-
darin: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 33056: 45669 | 45670 | 52875 | 52885