Attachment 50619 Details for Bug 36045 – Patch

[patch] Patch

36045.patch (text/plain), 2.87 KB, created by Andy Estes on 2010-03-12 12:05:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2010-03-12 12:05:52 PST

Size: 2.87 KB

patch

obsolete

>Index: WebKit/mac/ChangeLog
>===================================================================
>--- WebKit/mac/ChangeLog	(revision 55923)
>+++ WebKit/mac/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2010-03-12  Andy Estes  <aestes@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Expose WebPDFView's underlying PDFDocument.
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=36045
>+
>+        * WebView/WebDocumentPrivate.h: Create a new protocol called
>+        WebDocumentPDF.
>+        * WebView/WebPDFView.h: Have WebPDFView implement said protocol.
>+        * WebView/WebPDFView.mm:
>+        (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
>+        PDFDocument by implementing -(PDFDocument*)PDFDocument from
>+        WebDocumentPDF.
>+
> 2010-03-12  Andy Estes  <aestes@apple.com>
> 
>         Reviewed by Brady Eidson.
>Index: WebKit/mac/WebView/WebDocumentPrivate.h
>===================================================================
>--- WebKit/mac/WebView/WebDocumentPrivate.h	(revision 55885)
>+++ WebKit/mac/WebView/WebDocumentPrivate.h	(working copy)
>@@ -30,6 +30,7 @@
> #import <WebKit/WebHTMLView.h>
> 
> @class DOMDocument;
>+@class PDFDocument;
> 
> @protocol WebDocumentImage <NSObject>
> - (NSImage *)image;
>@@ -64,6 +65,10 @@ - (NSRect)selectionImageRect;
> - (NSView *)selectionView;
> @end
> 
>+@protocol WebDocumentPDF <WebDocumentText>
>+- (PDFDocument *)PDFDocument;
>+@end
>+
> @protocol WebDocumentIncrementalSearching
> /*!
> @method searchFor:direction:caseSensitive:wrap:startInSelection:
>Index: WebKit/mac/WebView/WebPDFView.h
>===================================================================
>--- WebKit/mac/WebView/WebPDFView.h	(revision 55885)
>+++ WebKit/mac/WebView/WebPDFView.h	(working copy)
>@@ -32,7 +32,7 @@ @class PDFDocument;
> @class PDFView;
> @class WebDataSource;
> 
>-@interface WebPDFView : NSView <WebDocumentView, WebDocumentSearching, WebDocumentIncrementalSearching, WebMultipleTextMatches, WebDocumentSelection, WebDocumentElement, _WebDocumentViewState, _WebDocumentZooming>
>+@interface WebPDFView : NSView <WebDocumentView, WebDocumentSearching, WebDocumentIncrementalSearching, WebMultipleTextMatches, WebDocumentSelection, WebDocumentElement, WebDocumentPDF, _WebDocumentViewState, _WebDocumentZooming>
> {
>     NSView *previewView;
>     PDFView *PDFSubview;
>@@ -51,5 +51,6 @@ + (NSArray *)supportedMIMETypes;
> + (NSBundle *)PDFKitBundle;
> 
> - (void)setPDFDocument:(PDFDocument *)doc;
>+- (PDFDocument *)PDFDocument;
> 
> @end
>Index: WebKit/mac/WebView/WebPDFView.mm
>===================================================================
>--- WebKit/mac/WebView/WebPDFView.mm	(revision 55885)
>+++ WebKit/mac/WebView/WebPDFView.mm	(working copy)
>@@ -182,6 +182,11 @@ - (void)setPDFDocument:(PDFDocument *)do
>     _ignoreScaleAndDisplayModeAndPageNotifications = NO;
> }
> 
>+- (PDFDocument *)PDFDocument
>+{
>+    return [PDFSubview document];
>+}
>+
> #pragma mark NSObject OVERRIDES
> 
> - (void)dealloc

Flags:

beidson: review+
beidson: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 36045: 50619