Attachment 49926 Details for Bug 34860 – [PATCH] Proposed fix.

[patch] [PATCH] Proposed fix.

select_error (text/plain), 2.72 KB, created by Pavel Feldman on 2010-03-03 11:16:50 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Pavel Feldman

Created: 2010-03-03 11:16:50 PST

Size: 2.72 KB

patch

obsolete

>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>index f655402..2b92db1 100644
>--- a/WebCore/ChangeLog
>+++ b/WebCore/ChangeLog
>@@ -2,6 +2,21 @@
> 
>         Reviewed by NOBODY (OOPS!).
> 
>+        Web Inspector: Clicking on an error should take me to the error
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=34860
>+
>+        * inspector/front-end/ResourceView.js:
>+        (WebInspector.ResourceView):
>+        (WebInspector.ResourceView.prototype._selectTab):
>+        (WebInspector.ResourceView.prototype.selectContentTab):
>+        * inspector/front-end/ResourcesPanel.js:
>+        (WebInspector.ResourcesPanel.prototype.showResource):
>+
>+2010-03-03  Pavel Feldman  <pfeldman@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>         Web Inspector: Remove sync access to resourceTrackingEnabled.
> 
>         https://bugs.webkit.org/show_bug.cgi?id=35693
>diff --git a/WebCore/inspector/front-end/ResourceView.js b/WebCore/inspector/front-end/ResourceView.js
>index b7b01ac..54cbb02 100644
>--- a/WebCore/inspector/front-end/ResourceView.js
>+++ b/WebCore/inspector/front-end/ResourceView.js
>@@ -47,7 +47,7 @@ WebInspector.ResourceView = function(resource)
>     this.tabsElement.appendChild(this.contentTabElement);
> 
>     this.headersTabElement.addEventListener("click", this._selectHeadersTab.bind(this), false);
>-    this.contentTabElement.addEventListener("click", this._selectContentTab.bind(this), false);
>+    this.contentTabElement.addEventListener("click", this.selectContentTab.bind(this), false);
> 
>     this.headersElement = document.createElement("div");
>     this.headersElement.className = "resource-view-headers";
>@@ -155,7 +155,7 @@ WebInspector.ResourceView.prototype = {
>             if (WebInspector.settings.resourceViewTab === "headers")
>                 this._selectHeadersTab();
>             else
>-                this._selectContentTab();
>+                this.selectContentTab();
>         } else
>             this._innerSelectContentTab();
>     },
>@@ -169,7 +169,7 @@ WebInspector.ResourceView.prototype = {
>         this.contentElement.addStyleClass("hidden");
>     },
> 
>-    _selectContentTab: function()
>+    selectContentTab: function()
>     {
>         WebInspector.settings.resourceViewTab = "content";
>         this._innerSelectContentTab();
>diff --git a/WebCore/inspector/front-end/ResourcesPanel.js b/WebCore/inspector/front-end/ResourcesPanel.js
>index c2ffe56..78661aa 100644
>--- a/WebCore/inspector/front-end/ResourcesPanel.js
>+++ b/WebCore/inspector/front-end/ResourcesPanel.js
>@@ -484,6 +484,7 @@ WebInspector.ResourcesPanel.prototype = {
> 
>         var view = this.resourceViewForResource(resource);
>         view.headersVisible = true;
>+        view.selectContentTab();
>         view.show(this.viewsContainerElement);
> 
>         if (line) {

Flags:

timothy: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 34860: 49926