Attachment 46554 Details for Bug 33015 – Removed the last timer of this test

[patch] Removed the last timer of this test

Removed-the-last-timer-of-this-test.patch (text/plain), 3.01 KB, created by Philippe Normand on 2010-01-14 03:56:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Normand

Created: 2010-01-14 03:56:49 PST

Size: 3.01 KB

patch

obsolete

>From 02693a185a8d08fdbd10e32ca10b3abf01aca794 Mon Sep 17 00:00:00 2001
>From: Philippe Normand <pnormand@igalia.com>
>Date: Wed, 13 Jan 2010 09:14:31 +0100
>Subject: [PATCH] Removed the last timer of this test
>
>---
> LayoutTests/ChangeLog                              |   10 ++++++++
> LayoutTests/media/video-seek-past-end-playing.html |   24 +++++++++----------
> LayoutTests/platform/gtk/Skipped                   |    3 --
> 3 files changed, 21 insertions(+), 16 deletions(-)
>
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index bbf8743..f7f3e8f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2010-01-13  Philippe Normand  <pnormand@igalia.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [GTK] Failing media/video-seek-past-end-playing.html
>+        https://bugs.webkit.org/show_bug.cgi?id=33015
>+
>+        * media/video-seek-past-end-playing.html: Removed the last timer of this test.
>+        * platform/gtk/Skipped: Unskip test above.
>+
> 2010-01-14  Eric Seidel  <eric@webkit.org>
> 
>         No review, rolling out r53249.
>diff --git a/LayoutTests/media/video-seek-past-end-playing.html b/LayoutTests/media/video-seek-past-end-playing.html
>index 15b0fd7..8b4b681 100644
>--- a/LayoutTests/media/video-seek-past-end-playing.html
>+++ b/LayoutTests/media/video-seek-past-end-playing.html
>@@ -26,22 +26,20 @@
>            // make sure time is advancing and seek past end
>            testExpected("mediaElement.currentTime", 0, '>');
>            run("video.currentTime = 500");
>-           setTimeout(seekCheck, 200);
>+        } else if (timeupdateEventCount == 10) {
>+           // Wait some more timeupdate events so we can check the
>+           // media engine performed the seek.
>+           consoleWrite("");
>+           testExpected("video.paused", false);
>+           testExpected("mediaElement.currentTime", 0, '>');
>+           consoleWrite("");
>+           // reset the counter to prevent infinite loop if the
>+           // test is re-executed manually.
>+           timeupdateEventCount = 0;
>+           endTest();
>         }
>     }
> 
>-    function seekCheck()
>-    {
>-        consoleWrite("");
>-        testExpected("video.paused", false);
>-        testExpected("mediaElement.currentTime", 0, '>');
>-        consoleWrite("");
>-        // reset the counter to prevent infinite loop if the
>-        // test is re-executed manually.
>-        timeupdateEventCount = 0;
>-        endTest();
>-    }
>-
>     mediaElement.addEventListener("timeupdate", timeupdate);
>     var mediaFile = findMediaFile("video", "content/test");
>     run("video.src = '" + mediaFile + "'");
>diff --git a/LayoutTests/platform/gtk/Skipped b/LayoutTests/platform/gtk/Skipped
>index 020a098..1f29701 100644
>--- a/LayoutTests/platform/gtk/Skipped
>+++ b/LayoutTests/platform/gtk/Skipped
>@@ -5745,6 +5745,3 @@ fast/profiler/dead-time.html
> 
> # Fails on and off (more often fails) on the release bot
> media/event-attributes.html
>-
>-# Fails on release bot, see https://bugs.webkit.org/show_bug.cgi?id=33015
>-media/video-seek-past-end-playing.html
>-- 
>1.6.3.3

Flags:

xan.lopez: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 33015: 46364 | 46430 | 46554