Attachment 434959 Details for Bug 228806 – For EWS

[patch] For EWS

bug-228806-20210804175859.patch (text/plain), 4.87 KB, created by Wenson Hsieh on 2021-08-04 17:59:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2021-08-04 17:59:00 PDT

Size: 4.87 KB

patch

obsolete

>Subversion Revision: 280652
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4f0219d670224f363283648eec133ca1aa576401..5fadeb6f315b61f7f2949ee84273beefdf18abef 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2021-08-04  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Adjust editing/deleting/ios/backspace-last-character.html to check that pressing backspace deletes one character
>+        https://bugs.webkit.org/show_bug.cgi?id=228806
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add test coverage for r280671 by augmenting an existing iOS editing test to verify that hitting backspace only
>+        deletes a single character in a `textarea`.
>+
>+        * editing/deleting/ios/backspace-last-character-expected.txt:
>+        * editing/deleting/ios/backspace-last-character.html:
>+
> 2021-08-04  Chris Dumez  <cdumez@apple.com>
> 
>         REGRESSION (r280541): [ BigSur Debug ] accessibility/roles-computedRoleString.html is timing out
>diff --git a/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt b/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt
>index 1ad7e382d04bd4aff2b7d561c453f36661c804ba..f6997c7927daef90c949f01c6b8411706f7c0bff 100644
>--- a/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt
>+++ b/LayoutTests/editing/deleting/ios/backspace-last-character-expected.txt
>@@ -1,19 +1,23 @@
> CONSOLE MESSAGE: Activating element and waiting for input session.
> CONSOLE MESSAGE: Waiting for element focus.
>-CONSOLE MESSAGE: Typing 'w'.
>+CONSOLE MESSAGE: Typing 'i'.
> CONSOLE MESSAGE: Waiting for first input event.
> CONSOLE MESSAGE: Hitting backspace.
> CONSOLE MESSAGE: Waiting for second input event.
>+CONSOLE MESSAGE: Hitting backspace again.
>+CONSOLE MESSAGE: Waiting for third input event.
> CONSOLE MESSAGE: Test complete.
>-This tests using the software keyboard and pressing 'w' then backspace deletes the 'w' and does not cause an assertion failure in a debug build.
>+This tests using the software keyboard and pressing 'i' then backspace twice to delete 'Hi'. This should not cause a debug assertion.
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> 
> PASS inputDidFocus became true
> PASS inputEventCount became 1
>-PASS document.getElementById("input").value is "w"
>+PASS document.getElementById("input").value is "Hi"
> PASS inputEventCount became 2
>+PASS document.getElementById("input").value is "H"
>+PASS inputEventCount became 3
> PASS document.getElementById("input").value is ""
> PASS successfullyParsed is true
> 
>diff --git a/LayoutTests/editing/deleting/ios/backspace-last-character.html b/LayoutTests/editing/deleting/ios/backspace-last-character.html
>index 1e48bd84ac099a243cb9a3b07a0792bcc62c363d..256c82576d785e2fbc40d78a477e762ff797a4fd 100644
>--- a/LayoutTests/editing/deleting/ios/backspace-last-character.html
>+++ b/LayoutTests/editing/deleting/ios/backspace-last-character.html
>@@ -6,7 +6,7 @@
> </head>
> <body>
> <div id="test-container">
>-    <textarea id="input"></textarea>
>+    <textarea id="input">H</textarea>
>     <textarea id="output" readonly></textarea>
> </div>
> <script>
>@@ -36,13 +36,13 @@ async function runTest()
>     console.log("Waiting for element focus.");
>     await new Promise(resolve => shouldBecomeEqual("inputDidFocus", "true", resolve));
> 
>-    console.log("Typing 'w'.");
>+    console.log("Typing 'i'.");
>     if (window.testRunner)
>-        await UIHelper.keyDown("w");
>+        await UIHelper.keyDown("i");
> 
>     console.log("Waiting for first input event.");
>     await new Promise(resolve => shouldBecomeEqual("inputEventCount", "1", resolve));
>-    shouldBeEqualToString('document.getElementById("input").value', "w");
>+    shouldBeEqualToString('document.getElementById("input").value', "Hi");
> 
>     console.log("Hitting backspace.");
>     if (window.testRunner)
>@@ -50,6 +50,14 @@ async function runTest()
> 
>     console.log("Waiting for second input event.");
>     await new Promise(resolve => shouldBecomeEqual("inputEventCount", "2", resolve));
>+    shouldBeEqualToString('document.getElementById("input").value', "H");
>+
>+    console.log("Hitting backspace again.");
>+    if (window.testRunner)
>+        await UIHelper.keyDown("\b");
>+
>+    console.log("Waiting for third input event.");
>+    await new Promise(resolve => shouldBecomeEqual("inputEventCount", "3", resolve));
>     shouldBeEqualToString('document.getElementById("input").value', "");
> 
>     console.log("Test complete.");
>@@ -57,7 +65,7 @@ async function runTest()
>     finishJSTest();
> }
> 
>-description("This tests using the software keyboard and pressing 'w' then <kbd>backspace</kbd> deletes the 'w' and does not cause an assertion failure in a debug build.");
>+description("This tests using the software keyboard and pressing 'i' then <kbd>backspace</kbd> twice to delete 'Hi'. This should not cause a debug assertion.");
> input.addEventListener("keydown", appendANewline);
> 
> runTest();

Actions: View | Formatted Diff | Diff

Attachments on bug 228806: 434959