Attachment 433505 Details for Bug 227951 – Patch

[patch] Patch

bug-227951-20210714180914.patch (text/plain), 2.88 KB, created by Imanol Fernandez on 2021-07-14 09:09:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Imanol Fernandez

Created: 2021-07-14 09:09:15 PDT

Size: 2.88 KB

patch

obsolete

>Subversion Revision: 279720
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e866e86a1e752774f8b872d505b8100ec7662894..0719b3daafe267ef033a10a0184b9c1f98041e34 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2021-07-14  Imanol Fernandez  <ifernandez@igalia.com>
>+
>+        Implement fullscreen in WPEView
>+        https://bugs.webkit.org/show_bug.cgi?id=227951
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Notify DOM fullscreen enter request to libwpe and handle exit fullscreen from libwpe.
>+
>+        * UIProcess/API/wpe/WPEView.cpp:
>+        (WKWPE::m_backend):
>+        (WKWPE::View::setFullScreen):
>+        * UIProcess/API/wpe/WPEView.h:
>+
> 2021-07-08  Per Arne  <pvollan@apple.com>
> 
>         Set Caption preferences in the UI process
>diff --git a/Source/WebKit/UIProcess/API/wpe/WPEView.cpp b/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>index bc236fc19b3c6cda48e880e94b5ac9bfc1886177..b0fa0a37e7b9fc6dd857fd13cca94d2f72ccb088 100644
>--- a/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>+++ b/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>@@ -257,6 +257,25 @@ View::View(struct wpe_view_backend* backend, const API::PageConfiguration& baseC
>     };
>     wpe_view_backend_set_input_client(m_backend, &s_inputClient, this);
> 
>+#if ENABLE(FULLSCREEN_API)
>+    static struct wpe_view_backend_fullscreen_client s_fullscreenClient = {
>+        // request_enter_fullscreen
>+        [](void* data)
>+        {
>+            auto& view = *reinterpret_cast<View*>(data);
>+            view.page().fullScreenManager()->requestEnterFullScreen();
>+        },
>+        // request_exit_fullscreen
>+        [](void* data)
>+        {
>+            auto& view = *reinterpret_cast<View*>(data);
>+            view.page().fullScreenManager()->requestExitFullScreen();
>+        },
>+        nullptr
>+    };
>+    wpe_view_backend_set_fullscreen_client(m_backend, &s_fullscreenClient, this);
>+#endif
>+
>     wpe_view_backend_initialize(m_backend);
> 
>     m_pageProxy->initializeWebPage();
>@@ -375,6 +394,14 @@ void View::close()
>     m_pageProxy->close();
> }
> 
>+#if ENABLE(FULLSCREEN_API)
>+void View::setFullScreen(bool fullScreenState)
>+{
>+    m_fullScreenModeActive = fullScreenState;
>+    wpe_view_backend_set_fullscreen(m_backend, fullScreenState);
>+};
>+#endif
>+
> #if ENABLE(ACCESSIBILITY)
> WebKitWebViewAccessible* View::accessible() const
> {
>diff --git a/Source/WebKit/UIProcess/API/wpe/WPEView.h b/Source/WebKit/UIProcess/API/wpe/WPEView.h
>index f924eac71e6fada05f6c43ec0e3b71d0d00f9280..29a3d9a446e5a7298ee3bdd325f2c22943c8efc7 100644
>--- a/Source/WebKit/UIProcess/API/wpe/WPEView.h
>+++ b/Source/WebKit/UIProcess/API/wpe/WPEView.h
>@@ -100,7 +100,7 @@ public:
> 
> #if ENABLE(FULLSCREEN_API)
>     bool isFullScreen() { return m_fullScreenModeActive; };
>-    void setFullScreen(bool fullScreenState) { m_fullScreenModeActive = fullScreenState; };
>+    void setFullScreen(bool);
> #endif
> 
> #if ENABLE(ACCESSIBILITY)

Actions: View | Formatted Diff | Diff

Attachments on bug 227951: 433505 | 433792 | 434998 | 435062