Attachment 42720 Details for Bug 25415 – What about....? (for the comment 41, 55 crasher)

[patch] What about....? (for the comment 41, 55 crasher)

25415-crasher55.patch (text/plain), 1.95 KB, created by Joanmarie Diggs on 2009-11-08 15:07:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joanmarie Diggs

Created: 2009-11-08 15:07:10 PST

Size: 1.95 KB

patch

obsolete

>From 49b1ac2aab448de9febeeb936e15a22bbcdc0282 Mon Sep 17 00:00:00 2001
>From: Joanmarie Diggs <joanmarie.diggs@gmail.com>
>Date: Sun, 8 Nov 2009 05:22:33 -0500
>Subject: [PATCH] 2009-11-08  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
>
>        Reviewed by NOBODY (OOPS!).
>
>        https://bugs.webkit.org/show_bug.cgi?id=25415
>        [GTK][ATK] Please implement support for get_text_at_offset
>
>        Fix a crasher that occurred with text which included newline
>        chars in the markup.
>
>        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
>        (convertUniCharToUTF8):
>---
> WebCore/ChangeLog                                  |   13 +++++++++++++
> .../gtk/AccessibilityObjectWrapperAtk.cpp          |    1 +
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
>diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
>index 05e4026..97afa33 100644
>--- a/WebCore/ChangeLog
>+++ b/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2009-11-08  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=25415
>+        [GTK][ATK] Please implement support for get_text_at_offset
>+
>+        Fix a crasher that occurred with text which included newline
>+        chars in the markup.
>+
>+        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
>+        (convertUniCharToUTF8):
>+
> 2009-11-07  Daniel Bates  <dbates@webkit.org>
> 
>         Reviewed by Darin Adler.
>diff --git a/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp b/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
>index 338a03c..8254a4c 100644
>--- a/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
>+++ b/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
>@@ -860,6 +860,7 @@ static gchar* convertUniCharToUTF8(const UChar* characters, gint length, int fro
>         len -= start;
>     }
> 
>+    utf8String = utf8Substr(stringUTF8.data(), from, to);
>     g_free(utf8String);
>     return g_string_free(ret, FALSE);
> }
>-- 
>1.6.3.3
>

Actions: View | Formatted Diff | Diff

Attachments on bug 25415: 30234 | 30370 | 30408 | 30465 | 30614 | 31049 | 31051 | 31052 | 32451 | 32471 | 33258 | 33259 | 33565 | 42544 | 42712 | 42720 | 42722 | 42855 | 43725 | 43778 | 43935 | 44046