Attachment 408768 Details for Bug 216510 – Patch

[patch] Patch

bug-216510-20200914171848.patch (text/plain), 5.81 KB, created by Chris Dumez on 2020-09-14 17:18:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2020-09-14 17:18:50 PDT

Size: 5.81 KB

patch

obsolete

>Subversion Revision: 267042
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 98751bb354917b170b906ab4f3497c62433bbd66..5d76ac0dcfc6bc01afd815cdad78a4c6b4800d3f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2020-09-14  Chris Dumez  <cdumez@apple.com>
>+
>+        Drop non-standard AudioBuffer.gain
>+        https://bugs.webkit.org/show_bug.cgi?id=216510
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Drop non-standard AudioBuffer.gain:
>+        - https://www.w3.org/TR/webaudio/#AudioBuffer
>+
>+        Blink does not expose this attribute either.
>+
>+        No new tests, updated existing test.
>+
>+        * Modules/webaudio/AudioBuffer.h:
>+        (WebCore::AudioBuffer::gain const): Deleted.
>+        (WebCore::AudioBuffer::setGain): Deleted.
>+        (): Deleted.
>+        * Modules/webaudio/AudioBuffer.idl:
>+        * Modules/webaudio/AudioBufferSourceNode.cpp:
>+        (WebCore::AudioBufferSourceNode::process):
>+
> 2020-09-14  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][FFC] Each in-flow child of a flex container becomes a flex item.
>diff --git a/Source/WebCore/Modules/webaudio/AudioBuffer.h b/Source/WebCore/Modules/webaudio/AudioBuffer.h
>index b695746d062c71cacb1f39109cbe5f651986ff14..e582d62a91fe562fd1b9a3fb633b044a25ea2c6f 100644
>--- a/Source/WebCore/Modules/webaudio/AudioBuffer.h
>+++ b/Source/WebCore/Modules/webaudio/AudioBuffer.h
>@@ -59,10 +59,6 @@ public:
>     Float32Array* channelData(unsigned channelIndex);
>     void zero();
> 
>-    // Scalar gain
>-    double gain() const { return m_gain; }
>-    void setGain(double gain) { m_gain = gain; }
>-
>     // Because an AudioBuffer has a JavaScript wrapper, which will be garbage collected, it may take a while for this object to be deleted.
>     // releaseMemory() can be called when the AudioContext goes away, so we can release the memory earlier than when the garbage collection happens.
>     // Careful! Only call this when the page unloads, after the AudioContext is no longer processing.
>@@ -76,7 +72,6 @@ private:
> 
>     void invalidate();
> 
>-    double m_gain { 1.0 }; // scalar gain
>     float m_sampleRate;
>     mutable Lock m_channelsLock;
>     size_t m_length;
>diff --git a/Source/WebCore/Modules/webaudio/AudioBuffer.idl b/Source/WebCore/Modules/webaudio/AudioBuffer.idl
>index c7e06ba7d092bf7cfb7a9040f308e29774964109..e36e56f0b668d8af5ba94dfc5d0a19d372be4d5b 100644
>--- a/Source/WebCore/Modules/webaudio/AudioBuffer.idl
>+++ b/Source/WebCore/Modules/webaudio/AudioBuffer.idl
>@@ -42,7 +42,4 @@
>     [MayThrowException] Float32Array getChannelData(unsigned long channelIndex);
>     [MayThrowException, EnabledBySetting=ModernUnprefixedWebAudio] undefined copyFromChannel(Float32Array destination, unsigned long channelNumber, optional unsigned long bufferOffset = 0);
>     [MayThrowException, EnabledBySetting=ModernUnprefixedWebAudio] undefined copyToChannel(Float32Array source, unsigned long channelNumber, optional unsigned long bufferOffset = 0);
>-
>-    // FIXME: This is not part of the specification.
>-    attribute unrestricted float gain; // linear gain (default 1.0)
> };
>diff --git a/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp b/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp
>index df2d90530da5c20e7f81f2d33d16bc0d5df69d35..a45652e1b34c0e07b29385661c21ba41e247f95d 100644
>--- a/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp
>+++ b/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp
>@@ -145,7 +145,7 @@ void AudioBufferSourceNode::process(size_t framesToProcess)
>     }
> 
>     // Apply the gain (in-place) to the output bus.
>-    float totalGain = legacyGainValue() * m_buffer->gain();
>+    float totalGain = legacyGainValue();
>     outputBus.copyWithGainFrom(outputBus, totalGain);
>     outputBus.clearSilentFlag();
> }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 0fab743b7f02e30361a0991f0828f12bb2a742fe..4199cc95a006f0931b052f5a9ae6f7c200eb3c32 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2020-09-14  Chris Dumez  <cdumez@apple.com>
>+
>+        Drop non-standard AudioBuffer.gain
>+        https://bugs.webkit.org/show_bug.cgi?id=216510
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Extend layout test coverage.
>+
>+        * webaudio/audiobuffer-expected.txt:
>+        * webaudio/audiobuffer.html:
>+
> 2020-09-14  Hector Lopez  <hector_i_lopez@apple.com>
> 
>         [ macOS iOS Debug ] imported/w3c/web-platform-tests/selection/*: 4 tests are flaky timeouts
>diff --git a/LayoutTests/webaudio/audiobuffer-expected.txt b/LayoutTests/webaudio/audiobuffer-expected.txt
>index bfc5633d4a360490e8d65166f7adb5156ae1abac..e91b4794e8b986751ac70480fde4d1045d63b40e 100644
>--- a/LayoutTests/webaudio/audiobuffer-expected.txt
>+++ b/LayoutTests/webaudio/audiobuffer-expected.txt
>@@ -12,6 +12,8 @@ PASS getChannelData(1) returns a Float32Array object.
> PASS getChannelData(2) returns a Float32Array object.
> PASS getChannelData(3) returns a Float32Array object.
> PASS Exception has been thrown correctly when index is not less than numberOfChannels.
>+PASS buffer.gain is undefined.
>+PASS AudioBuffer.prototype.gain is undefined.
> PASS context.createBuffer(null, false) threw exception TypeError: Argument 1 ('buffer') to webkitAudioContext.createBuffer must be an instance of ArrayBuffer.
> PASS successfullyParsed is true
> 
>diff --git a/LayoutTests/webaudio/audiobuffer.html b/LayoutTests/webaudio/audiobuffer.html
>index f0dddf0c45e526b5698c21e3afe65596b3aef658..5f66e6d29e3c80080adb458299ac4d5547fb7a18 100644
>--- a/LayoutTests/webaudio/audiobuffer.html
>+++ b/LayoutTests/webaudio/audiobuffer.html
>@@ -49,6 +49,9 @@ try {
>     testPassed("Exception has been thrown correctly when index is not less than numberOfChannels.");
> }
> 
>+shouldBeUndefined("buffer.gain");
>+shouldBeUndefined("AudioBuffer.prototype.gain");
>+
> shouldThrowErrorName("context.createBuffer(null, false)", "TypeError");
> 
> </script>

Actions: View | Formatted Diff | Diff

Attachments on bug 216510: 408768