Attachment 407406 Details for Bug 215890 – Patch

[patch] Patch

bug-215890-20200827181444.patch (text/plain), 14.69 KB, created by youenn fablet on 2020-08-27 09:14:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2020-08-27 09:14:45 PDT

Size: 14.69 KB

patch

obsolete

>Subversion Revision: 266231
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 067fc2190c316acc64d1e3a1d073622957889a8c..a8cf51f15316eb33bc3fd631073f51db09d4af12 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2020-08-27  Youenn Fablet  <youenn@apple.com>
>+
>+        initializeReadableStream should check for highWaterMark be undefined
>+        https://bugs.webkit.org/show_bug.cgi?id=215890
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by updated tests.
>+
>+        * Modules/streams/ReadableStream.js:
>+        (initializeReadableStream):
>+
> 2020-08-27  Youenn Fablet  <youenn@apple.com>
> 
>         Fix propagation of errors in TransformStream
>diff --git a/Source/WebCore/Modules/streams/ReadableStream.js b/Source/WebCore/Modules/streams/ReadableStream.js
>index cbcb69e03789aa999ec06c11eb0e65bd98dce523..ce4995011a99626dd55f3b9dbd596843806143b1 100644
>--- a/Source/WebCore/Modules/streams/ReadableStream.js
>+++ b/Source/WebCore/Modules/streams/ReadableStream.js
>@@ -51,7 +51,7 @@ function initializeReadableStream(underlyingSource, strategy)
>     if (@getByIdDirectPrivate(underlyingSource, "pull") !== @undefined) {
>         const size = @getByIdDirectPrivate(strategy, "size");
>         const highWaterMark = @getByIdDirectPrivate(strategy, "highWaterMark");
>-        @setupReadableStreamDefaultController(this, underlyingSource, size, highWaterMark ? highWaterMark : 1, @getByIdDirectPrivate(underlyingSource, "start"), @getByIdDirectPrivate(underlyingSource, "pull"), @getByIdDirectPrivate(underlyingSource, "cancel"));
>+        @setupReadableStreamDefaultController(this, underlyingSource, size, highWaterMark !== @undefined ? highWaterMark : 1, @getByIdDirectPrivate(underlyingSource, "start"), @getByIdDirectPrivate(underlyingSource, "pull"), @getByIdDirectPrivate(underlyingSource, "cancel"));
>         return this;
>     }
> 
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 9b8baaf4d06cca1b2b60a528b5a23919d5969abb..6863cdf84afc2a8fc1c5f18557d21eb309143bf9 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,21 @@
>+2020-08-27  Youenn Fablet  <youenn@apple.com>
>+
>+        initializeReadableStream should check for highWaterMark be undefined
>+        https://bugs.webkit.org/show_bug.cgi?id=215890
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/streams/transform-streams/backpressure.any-expected.txt:
>+        * web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt:
>+        * web-platform-tests/streams/transform-streams/errors.any-expected.txt:
>+        * web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt:
>+        * web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt:
>+        * web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt:
>+        * web-platform-tests/streams/transform-streams/strategies.any-expected.txt:
>+        * web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt:
>+        * web-platform-tests/streams/transform-streams/terminate.any-expected.txt:
>+        * web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt:
>+
> 2020-08-27  Youenn Fablet  <youenn@apple.com>
> 
>         Fix propagation of errors in TransformStream
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt
>index 927e5f1b9e18f04cfdf071aea0278301bae415fd..e6e114ac61eeba1b0d1e750b872bbf5cb10c92d5 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt
>@@ -1,6 +1,6 @@
> CONSOLE MESSAGE: Unhandled Promise Rejection: error1: error1 message
> 
>-FAIL backpressure allows no transforms with a default identity transform and no reader assert_array_equals: transform should not be called lengths differ, expected array [] length 0, got ["transform", "a"] length 2
>+PASS backpressure allows no transforms with a default identity transform and no reader 
> PASS backpressure only allows one transform() with a identity transform with a readable HWM of 1 and no reader 
> PASS transform() should keep being called as long as there is no backpressure 
> PASS writes should resolve as soon as transform completes 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt
>index 6588b71823819aa1b645f49c989455176c194c99..c6af95092685abdcc0e4db74c62626f8e0db8712 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt
>@@ -1,5 +1,5 @@
> 
>-FAIL backpressure allows no transforms with a default identity transform and no reader assert_array_equals: transform should not be called lengths differ, expected array [] length 0, got ["transform", "a"] length 2
>+PASS backpressure allows no transforms with a default identity transform and no reader 
> PASS backpressure only allows one transform() with a identity transform with a readable HWM of 1 and no reader 
> PASS transform() should keep being called as long as there is no backpressure 
> PASS writes should resolve as soon as transform completes 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt
>index ec9c8ad997e36a5fa3e303071fa8bcce5a884381..c1125fb4d9a2e87655ed6ed1a854249e67a233e0 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt
>@@ -17,6 +17,6 @@ PASS controller.error() should do nothing after readable.cancel()
> PASS controller.error() should do nothing after writable.abort() has completed 
> PASS controller.error() should do nothing after a transformer method has thrown an exception 
> PASS erroring during write with backpressure should result in the write failing 
>-FAIL a write() that was waiting for backpressure should reject if the writable is aborted assert_unreached: Should have rejected: read() should reject Reached unreachable code
>+PASS a write() that was waiting for backpressure should reject if the writable is aborted 
> PASS the readable should be errored with the reason passed to the writable abort() method 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt
>index ec9c8ad997e36a5fa3e303071fa8bcce5a884381..c1125fb4d9a2e87655ed6ed1a854249e67a233e0 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt
>@@ -17,6 +17,6 @@ PASS controller.error() should do nothing after readable.cancel()
> PASS controller.error() should do nothing after writable.abort() has completed 
> PASS controller.error() should do nothing after a transformer method has thrown an exception 
> PASS erroring during write with backpressure should result in the write failing 
>-FAIL a write() that was waiting for backpressure should reject if the writable is aborted assert_unreached: Should have rejected: read() should reject Reached unreachable code
>+PASS a write() that was waiting for backpressure should reject if the writable is aborted 
> PASS the readable should be errored with the reason passed to the writable abort() method 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt
>index 9e376e6d6b25a07e17020b3249af5e76d7f83663..f70d7718c2305585ce01821e55dfb6d03299a9b1 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt
>@@ -5,7 +5,7 @@ PASS error() inside size() should work
> PASS desiredSize inside size() should work 
> PASS readable cancel() inside size() should work 
> PASS pipeTo() inside size() should work 
>-FAIL read() inside of size() should work assert_false: expected false got true
>+PASS read() inside of size() should work 
> PASS writer.write() inside size() should work 
> PASS synchronous writer.write() inside size() should work 
> PASS writer.close() inside size() should work 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt
>index 9e376e6d6b25a07e17020b3249af5e76d7f83663..f70d7718c2305585ce01821e55dfb6d03299a9b1 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt
>@@ -5,7 +5,7 @@ PASS error() inside size() should work
> PASS desiredSize inside size() should work 
> PASS readable cancel() inside size() should work 
> PASS pipeTo() inside size() should work 
>-FAIL read() inside of size() should work assert_false: expected false got true
>+PASS read() inside of size() should work 
> PASS writer.write() inside size() should work 
> PASS synchronous writer.write() inside size() should work 
> PASS writer.close() inside size() should work 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt
>index b135b30b886a5912853744868d09a7a2f8ceaad8..a66a57c68084c28f80faebb01707ad734ee098c2 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt
>@@ -3,7 +3,7 @@ PASS writableStrategy highWaterMark should work
> PASS readableStrategy highWaterMark should work 
> PASS writable should have the correct size() function 
> PASS default writable strategy should be equivalent to { highWaterMark: 1 } 
>-FAIL default readable strategy should be equivalent to { highWaterMark: 0 } assert_equals: desiredSize should be 0 expected 0 but got 1
>+PASS default readable strategy should be equivalent to { highWaterMark: 0 } 
> PASS a RangeError should be thrown for an invalid highWaterMark 
> PASS writableStrategy highWaterMark should be converted to a number 
> PASS readableStrategy highWaterMark should be converted to a number 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt
>index b135b30b886a5912853744868d09a7a2f8ceaad8..a66a57c68084c28f80faebb01707ad734ee098c2 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt
>@@ -3,7 +3,7 @@ PASS writableStrategy highWaterMark should work
> PASS readableStrategy highWaterMark should work 
> PASS writable should have the correct size() function 
> PASS default writable strategy should be equivalent to { highWaterMark: 1 } 
>-FAIL default readable strategy should be equivalent to { highWaterMark: 0 } assert_equals: desiredSize should be 0 expected 0 but got 1
>+PASS default readable strategy should be equivalent to { highWaterMark: 0 } 
> PASS a RangeError should be thrown for an invalid highWaterMark 
> PASS writableStrategy highWaterMark should be converted to a number 
> PASS readableStrategy highWaterMark should be converted to a number 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt
>index 5076d9256f0b76b96cf5727d61d0bdccb23ce993..424b62e57c0fcdf08713665bfb68d94f9e8966fb 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt
>@@ -1,6 +1,9 @@
> CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: the stream has been terminated
>+CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: the stream has been terminated
>+
>+Harness Error (FAIL), message = Unhandled rejection: the stream has been terminated
> 
>-FAIL controller.terminate() should error pipeTo() assert_array_equals: transform() should have seen no chunks lengths differ, expected array [] length 0, got ["transform", 0] length 2
>+PASS controller.terminate() should error pipeTo() 
> PASS controller.terminate() should prevent remaining chunks from being processed 
> PASS controller.enqueue() should throw after controller.terminate() 
> PASS controller.error() after controller.terminate() with queued chunk should error the readable 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt
>index 5b0f38d494115931629ee08d40e47914c8e78be1..887ccbfa0f81e606a601dc04a923f79d064db667 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt
>@@ -1,5 +1,7 @@
> 
>-FAIL controller.terminate() should error pipeTo() assert_array_equals: transform() should have seen no chunks lengths differ, expected array [] length 0, got ["transform", 0] length 2
>+Harness Error (FAIL), message = Unhandled rejection: the stream has been terminated
>+
>+PASS controller.terminate() should error pipeTo() 
> PASS controller.terminate() should prevent remaining chunks from being processed 
> PASS controller.enqueue() should throw after controller.terminate() 
> PASS controller.error() after controller.terminate() with queued chunk should error the readable

Actions: View | Formatted Diff | Diff

Attachments on bug 215890: 407406 | 407409