Attachment 406030 Details for Bug 215156 – Patch

[patch] Patch

for-review-3.txt (text/plain), 1.87 KB, created by Beth Dakin on 2020-08-05 13:18:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Beth Dakin

Created: 2020-08-05 13:18:36 PDT

Size: 1.87 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 265276)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2020-08-04  Beth Dakin  <bdakin@apple.com>
>+
>+        Make report-non-inclusive-language ignore files within .svn and .git
>+        https://bugs.webkit.org/show_bug.cgi?id=215156
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/report-non-inclusive-language:
>+
> 2020-08-04  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [webkitcorepy] REGRESSION(r265254): autoinstaller is failing to execute setup.py on win32 Python
>Index: Tools/Scripts/report-non-inclusive-language
>===================================================================
>--- Tools/Scripts/report-non-inclusive-language	(revision 265267)
>+++ Tools/Scripts/report-non-inclusive-language	(working copy)
>@@ -33,7 +33,8 @@ import argparse, os, re
> #   Clever default for use on WebKit source tree instead of current directory by default.
> #   Report third party sources separately from WebKit project files.
> #   Skip known examples on an exception list that we don't intend to fix.
>-#   Replace special cases for ChangeLog, ".order", and ".xcuserstate" files with something smarter.
>+#   Replace special cases for ChangeLog, ".order", ".xcuserstate", ".git", ".svn"
>+#   files with something smarter.
> 
> # Hard-coded for now, could read these out of a file instead.
> # Term, then the regular expression for that term.
>@@ -54,7 +55,12 @@ for term in nonInclusiveTerms:
> 
> root = os.getcwd()
> for subroot, directories, files in os.walk(root):
>+    directories = [directory for directory in directories if not directory.startswith(".svn")]
>     prefix = subroot[len(root) + 1:]
>+    if ".svn" in prefix:
>+        continue
>+    if ".git" in prefix:
>+        continue
>     for file in files:
>         if file.startswith("ChangeLog"):
>             continue

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 215156: 405985 | 406029 | 406030 | 406031