WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
patch
keyframe-rem-unit-2.patch (text/plain), 2.98 KB, created by
Antti Koivisto
on 2020-05-19 08:06:29 PDT
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Antti Koivisto
Created:
2020-05-19 08:06:29 PDT
Size:
2.98 KB
patch
obsolete
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index dec2f053eff..eb8821b8e9f 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,14 @@ >+2020-05-19 Antti Koivisto <antti@apple.com> >+ >+ Animation of font-size with rem values is incorrect >+ https://bugs.webkit.org/show_bug.cgi?id=194765 >+ <rdar://problem/48171742> >+ >+ Reviewed by Antoine Quint. >+ >+ * animations/keyframe-rem-unit-expected.html: Added. >+ * animations/keyframe-rem-unit.html: Added. >+ > 2020-05-19 Zan Dobersek <zdobersek@igalia.com> > > Unreviewed WPE gardening. Sifted through the crash expectations >diff --git a/LayoutTests/animations/keyframe-rem-unit-expected.html b/LayoutTests/animations/keyframe-rem-unit-expected.html >new file mode 100644 >index 00000000000..a5c2b7f1004 >--- /dev/null >+++ b/LayoutTests/animations/keyframe-rem-unit-expected.html >@@ -0,0 +1,8 @@ >+<!DOCTYPE html> >+<style> >+div { >+ font-size: 6rem; >+} >+</style> >+<div>Hello world!</div> >+ >diff --git a/LayoutTests/animations/keyframe-rem-unit.html b/LayoutTests/animations/keyframe-rem-unit.html >new file mode 100644 >index 00000000000..2b479e3d1c1 >--- /dev/null >+++ b/LayoutTests/animations/keyframe-rem-unit.html >@@ -0,0 +1,16 @@ >+<!DOCTYPE html> >+<style> >+div { >+ animation: anim 16ms linear forwards; >+} >+@keyframes anim { >+ 0% { >+ font-size: 6rem; >+ } >+ 100% { >+ font-size: 6rem; >+ } >+} >+</style> >+<div>Hello world!</div> >+ >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index c46b272bba1..830a494bf99 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,20 @@ >+2020-05-19 Antti Koivisto <antti@apple.com> >+ >+ Animation of font-size with rem values is incorrect >+ https://bugs.webkit.org/show_bug.cgi?id=194765 >+ <rdar://problem/48171742> >+ >+ Reviewed by Antoine Quint. >+ >+ Test: animations/keyframe-rem-unit.html >+ >+ 'rem' computation fails on first style resolution because the document element style is not available. >+ >+ * style/StyleResolver.cpp: >+ (WebCore::Style::Resolver::styleForKeyframe): >+ >+ Provide the override value, needed because the style can't be found from DOM tree yet. >+ > 2020-05-19 Michael Catanzaro <mcatanzaro@gnome.org> > > REGRESSION(r257463): [GTK] Build failure with -DENABLE_GLES2=ON >diff --git a/Source/WebCore/style/StyleResolver.cpp b/Source/WebCore/style/StyleResolver.cpp >index 0685beec6d7..ec1a7ac98e9 100644 >--- a/Source/WebCore/style/StyleResolver.cpp >+++ b/Source/WebCore/style/StyleResolver.cpp >@@ -260,7 +260,7 @@ std::unique_ptr<RenderStyle> Resolver::styleForKeyframe(const Element& element, > MatchResult result; > result.authorDeclarations.append({ &keyframe->properties() }); > >- auto state = State(element, nullptr); >+ auto state = State(element, nullptr, m_overrideDocumentElementStyle); > > state.setStyle(RenderStyle::clonePtr(*elementStyle)); > state.setParentStyle(RenderStyle::clonePtr(*elementStyle));
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194765
:
399640
|
399643
|
399733
| 399735