Attachment 396518 Details for Bug 209964 – Patch

[patch] Patch

bug-209964-20200415125549.patch (text/plain), 6.11 KB, created by Paulo Matos on 2020-04-15 03:56:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo Matos

Created: 2020-04-15 03:56:01 PDT

Size: 6.11 KB

patch

obsolete

>Subversion Revision: 260121
>diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests
>index c4e08f0ff4f6dbba7813faac9e87163afbc80477..a520928572955712399f706761ac543927bcec80 100755
>--- a/Tools/Scripts/run-jsc-stress-tests
>+++ b/Tools/Scripts/run-jsc-stress-tests
>@@ -687,6 +687,9 @@ def runBytecodeCacheImpl(optionalTestSpecificOptions, *additionalEnv)
>         return
>     end
>     options = BASE_OPTIONS + $testSpecificRequiredOptions + FTL_OPTIONS + optionalTestSpecificOptions
>+
>+    # Ensure options that contain spaces are passed to the shell helper surrounded by quotes
>+    options = options.map { |opt| if opt.match(/^\S*$/) then opt else "'" + opt + "'" end }
>     addRunCommand("bytecode-cache", ["sh", (pathToHelpers + "bytecode-cache-test-helper.sh").to_s, pathToVM.to_s, $benchmark.to_s] + options, silentOutputHandler, simpleErrorHandler, *additionalEnv)
> end
> 
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index db90f5f0273326467ef709f623e6977b230e90c1..36f26f3c0680282e247da9216db8d911988a9a2b 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2020-04-15  Paulo Matos  <pmatos@igalia.com>
>+
>+        Re-enable previously skipped mips tests
>+        https://bugs.webkit.org/show_bug.cgi?id=209964
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Followup to r259454 - where we re-enabled a few stress tests for arm.
>+
>+        * stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js:
>+        * stress/dont-range-based-iterate-vector-that-is-mutated.js:
>+        * stress/ensure-code-block-is-not-precise-allocation.js:
>+        * stress/generator-cell-with-type.js:
>+        * stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js:
>+        * stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js:
>+        * stress/toctou-having-a-bad-time-new-array.js:
>+
> 2020-04-15  Devin Rousso  <drousso@apple.com>
> 
>         [ESNext] Implement logical assignment operators
>diff --git a/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js b/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js
>index 2d6a9745e92c84d2ec6eece44543f5aace3c66c5..cbcfef7c5116ac727199832519f8a941da573d45 100644
>--- a/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js
>+++ b/JSTests/stress/JSArrayBufferView-byteOffset-is-racy-from-compiler-thread.js
>@@ -1,4 +1,3 @@
>-//@ skip if ["mips"].include?($architecture)
> //@ slow!
> //@ runDefault("--jitPolicyScale=0")
> 
>diff --git a/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js b/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js
>index 5acab939e904da142a510f805d7df95183d99fd8..8ec678a1edd00d8cb80f29831d9c6f63baad4cfe 100644
>--- a/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js
>+++ b/JSTests/stress/dont-range-based-iterate-vector-that-is-mutated.js
>@@ -1,4 +1,3 @@
>-//@ skip if not $jitTests and $architecture =~ /mips/ and $hostOS == "linux"
> // Should not crash when run with ASAN.
> 
> function foo(arr1, arr2) {
>diff --git a/JSTests/stress/ensure-code-block-is-not-precise-allocation.js b/JSTests/stress/ensure-code-block-is-not-precise-allocation.js
>index 9c96f99433af3e5f278b367eaa1b3b29411c18b9..430a137ec6c1575d37d1173aa20488fd014c096c 100644
>--- a/JSTests/stress/ensure-code-block-is-not-precise-allocation.js
>+++ b/JSTests/stress/ensure-code-block-is-not-precise-allocation.js
>@@ -1,4 +1,4 @@
>-//@ if $architecture == "mips" then skip else slow! end
>+//@ slow!
> // Does not crash.
> function foo() {
>     +new Proxy({}, {get: foo});
>diff --git a/JSTests/stress/generator-cell-with-type.js b/JSTests/stress/generator-cell-with-type.js
>index 20fec42a910df41b443f47eb9690528d8aee0845..7fc0772bcffa6066bd5fe3cccd5f40bd99923f8f 100644
>--- a/JSTests/stress/generator-cell-with-type.js
>+++ b/JSTests/stress/generator-cell-with-type.js
>@@ -1,5 +1,8 @@
> // This test takes too long on mips devices.
>-//@ skip if ["mips"].include?($architecture)
>+//@ requireOptions("-e", "let hardness=1e5") if ["mips"].include?($architecture)
>+
>+hardness = typeof(hardness) === 'undefined' ? 1e6 : hardness;
>+
> function shouldBe(actual, expected) {
>     if (actual !== expected)
>         throw new Error('bad value: ' + actual);
>@@ -32,10 +35,10 @@ function test(gen)
> }
> noInline(test);
> var gen = generator();
>-for (var i = 0; i < 1e6; ++i)
>+for (var i = 0; i < hardness; ++i)
>     test(gen);
> 
>-for (var i = 0; i < 1e6; ++i) {
>+for (var i = 0; i < hardness; ++i) {
>     test(gen);
>     shouldThrow(() => {
>         test({
>diff --git a/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js b/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js
>index fc3c2cc21c8da4f4da768b1606263568f3db271f..52229bd0ec668bcafeb58d676f0bc6936e50b77d 100644
>--- a/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js
>+++ b/JSTests/stress/racy-slow-put-cloned-arguments-when-having-a-bad-time.js
>@@ -1,5 +1,4 @@
> //@ requireOptions("--jitPolicyScale=0")
>-//@ skip if ["mips"].include?($architecture)
> //@ slow!
> 
> for (let j = 0; j < 500; j++) {
>diff --git a/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js b/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js
>index 0c337083acbc37354ac1a72ee37ac2aa6d2726a2..947a302408589b4f2f97c4378b29259e1438a82d 100644
>--- a/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js
>+++ b/JSTests/stress/symbol-is-destructed-before-refing-underlying-symbol-impl.js
>@@ -1,4 +1,4 @@
>-//@ skip if $buildType == "debug" || ["mips"].include?($architecture)
>+//@ skip if $buildType == "debug"
> //@ slow!
> //@ runDefault("--collectContinuously=1", "--slowPathAllocsBetweenGCs=100")
> 
>diff --git a/JSTests/stress/toctou-having-a-bad-time-new-array.js b/JSTests/stress/toctou-having-a-bad-time-new-array.js
>index 66b762208fa211cefef1a21b5db2681976751429..f1f4059c7be4ee38c1f4c3b377d8f2ebae20d438 100644
>--- a/JSTests/stress/toctou-having-a-bad-time-new-array.js
>+++ b/JSTests/stress/toctou-having-a-bad-time-new-array.js
>@@ -1,4 +1,4 @@
>-//@ skip if $buildType == "debug" or ["mips"].include?($architecture)
>+//@ skip if $buildType == "debug"
> 
> let code = `
>     function foo() {

Actions: View | Formatted Diff | Diff

Attachments on bug 209964: 395373 | 396400 | 396518 | 396628 | 396629 | 396742 | 396759 | 396760