Attachment 395603 Details for Bug 210066 – REVERT of r259469

[patch] REVERT of r259469

bug-210066-20200406125819.patch (text/plain), 4.38 KB, created by WebKit Commit Bot on 2020-04-06 12:58:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2020-04-06 12:58:19 PDT

Size: 4.38 KB

patch

obsolete

>Subversion Revision: 259587
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 74f5e0ffb5c6393d4b22bd59a10e9a33f628a97d..91912466701ff7fd5e1249e6739694323d641539 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2020-04-06  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, reverting r259469.
>+        https://bugs.webkit.org/show_bug.cgi?id=210066
>+
>+        Introduced media playback regression (Requested by perarne on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "[iOS] Deny mach lookup access to the runningboard service in
>+        the WebContent process"
>+        https://bugs.webkit.org/show_bug.cgi?id=209933
>+        https://trac.webkit.org/changeset/259469
>+
> 2020-04-06  VÃctor Manuel JÃ¡quez Leal  <vjaquez@igalia.com>
> 
>         [GTK] Remove unused header in web process
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>index 1313917f3acecf5ff9db4130c9723850ce0c5b84..fb15761144551b792891fd3283a27544d775e6d1 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>@@ -554,8 +554,8 @@
>     (deny ipc-posix-sem-create ipc-posix-sem-post ipc-posix-sem-unlink ipc-posix-sem-wait)
>     (allow ipc-posix-sem-open))
> 
>-(deny mach-lookup (with telemetry-backtrace)
>-    (global-name "com.apple.runningboard")
>+(allow mach-lookup (with telemetry)
>+    (global-name "com.apple.runningboard") ;; Needed by process assertion code (ProcessTaskStateObserver).
> )
> 
> (allow system-sched
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 35661a03a01b1f7a2434736643021e80ae91f367..1f045fcfe0d3487fc8ea54ec4c58b21f403997c7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2020-04-06  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, reverting r259469.
>+        https://bugs.webkit.org/show_bug.cgi?id=210066
>+
>+        Introduced media playback regression (Requested by perarne on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "[iOS] Deny mach lookup access to the runningboard service in
>+        the WebContent process"
>+        https://bugs.webkit.org/show_bug.cgi?id=209933
>+        https://trac.webkit.org/changeset/259469
>+
> 2020-04-06  Jacob Uphoff  <jacob_uphoff@apple.com>
> 
>         [ macOS ] inspector/debugger/break-in-constructor-before-super.html is a flaky failure
>diff --git a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt b/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
>index 4b2935a4be44b19cf1557a9acda9d3cf88d80937..ea83cae570ea4f4c4fa90bd0270987f035790aae 100644
>--- a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
>+++ b/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
>@@ -27,4 +27,3 @@ PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebConte
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iconservices") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.mapdb") is false
> PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.frontboard.systemappservices") is false
>-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.runningboard") is false
>diff --git a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html b/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
>index 348bf59a39c6da22e5d21ca34e9355d4e5f94191..8814f3936e77f1ff7b7d0472868a2e0267a0082b 100644
>--- a/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
>+++ b/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
>@@ -30,7 +30,6 @@ if (window.internals) {
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.iconservices\")");
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.mapdb\")");
>     shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.frontboard.systemappservices\")");
>-    shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.runningboard\")");
> }
> </script>
> </head>

Actions: View | Formatted Diff | Diff

Attachments on bug 210066: 395603