Attachment 388491 Details for Bug 206618 – Patch

[patch] Patch

bug-206618-20200122171446.patch (text/plain), 1.42 KB, created by Jonathan Bedard on 2020-01-22 17:14:47 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2020-01-22 17:14:47 PST

Size: 1.42 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 254953)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2020-01-22  Jonathan Bedard  <jbedard@apple.com>
>+
>+        Fix iOS 13.2 iphoneos build
>+        https://bugs.webkit.org/show_bug.cgi?id=206618
>+
>+        Reviewed by Alexey Proskuryakov.
>+
>+        * Scripts/webkitdirs.pm:
>+        (XcodeOptions): Relax provisioning profile rules on embedded SDKs.
>+
> 2020-01-22  Brady Eidson  <beidson@apple.com>
> 
>         REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated
>Index: Tools/Scripts/webkitdirs.pm
>===================================================================
>--- Tools/Scripts/webkitdirs.pm	(revision 254953)
>+++ Tools/Scripts/webkitdirs.pm	(working copy)
>@@ -888,7 +888,8 @@ sub XcodeOptions
>     push @options, @baseProductDirOption;
>     push @options, "ARCHS=$architecture" if $architecture;
>     push @options, "SDKROOT=$xcodeSDK" if $xcodeSDK;
>-    if (willUseIOSDeviceSDK()) {
>+    if (willUseIOSDeviceSDK() || willUseWatchDeviceSDK() || willUseAppleTVDeviceSDK()) {
>+        push @options, "-IDEProvisioningProfileSupportRelaxed=YES";
>         push @options, "ENABLE_BITCODE=NO";
>         if (hasIOSDevelopmentCertificate()) {
>             # FIXME: May match more than one installed development certificate.

Flags:

commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 206618: 388477 | 388491