Attachment 378838 Details for Bug 201812 – Patch v1

[patch] Patch v1

bug-201812-20190915220337.patch (text/plain), 1.83 KB, created by David Kilzer (:ddkilzer) on 2019-09-15 22:02:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-09-15 22:02:06 PDT

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 249852
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 705d8552d2322d811eafd0a45dd5fbe4ca8fb617..e977f17a7c678a5b5516bc785f0281f1789e4939 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-09-15  David Kilzer  <ddkilzer@apple.com>
>+
>+        REGRESSION (r243113): Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate
>+        <https://webkit.org/b/201812>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/NSAttributedString.mm:
>+        (-[_WKAttributedStringNavigationDelegate dealloc]): Add method
>+        to release instance variable blocks to fix potential leaks.
>+
> 2019-09-15  David Kilzer  <ddkilzer@apple.com>
> 
>         REGRESSION (r248592): Leak of CFDictionaryRef in WebKit::NetworkRTCProvider::proxyInfoFromSession()
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm b/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm
>index 78f5a3a0ba96fdc9cc8ee60ddd130fde1a9cbd2a..d58ec81fc9cfdd434f31320b2d3c806fd9173e1f 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm
>@@ -63,6 +63,22 @@ @end
> 
> @implementation _WKAttributedStringNavigationDelegate
> 
>+- (void)dealloc
>+{
>+    [_webContentProcessDidTerminate release];
>+    _webContentProcessDidTerminate = nil;
>+    [_decidePolicyForNavigationAction release];
>+    _decidePolicyForNavigationAction = nil;
>+    [_didFailProvisionalNavigation release];
>+    _didFailProvisionalNavigation = nil;
>+    [_didFailNavigation release];
>+    _didFailNavigation = nil;
>+    [_didFinishNavigation release];
>+    _didFinishNavigation = nil;
>+
>+    [super dealloc];
>+}
>+
> - (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView
> {
>     if (_webContentProcessDidTerminate)

Actions: View | Formatted Diff | Diff

Attachments on bug 201812: 378838