Attachment 366767 Details for Bug 196325 – PatchForFix

[patch] PatchForFix

patch_fix196325 (text/plain), 1.44 KB, created by Robin Morisset on 2019-04-04 16:13:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-04-04 16:13:03 PDT

Size: 1.44 KB

patch

obsolete

>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index cd654a12d2c..001601c2e4e 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-04-04  Robin Morisset  <rmorisset@apple.com>
>+
>+        B3ReduceStrength should know that Mul distributes over Add and Sub
>+        https://bugs.webkit.org/show_bug.cgi?id=196325
>+        <rdar://problem/49441650>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix some obviously wrong code that was due to an accidental copy-paste.
>+        It made the entire optimization dead code that never ran.
>+
>+        * b3/B3ReduceStrength.cpp:
>+
> 2019-04-04  Saam Barati  <sbarati@apple.com>
> 
>         Unreviewed, build fix for CLoop after r243886
>diff --git a/Source/JavaScriptCore/b3/B3ReduceStrength.cpp b/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
>index 9e6215942f3..7e22c29d6d4 100644
>--- a/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
>+++ b/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
>@@ -2345,9 +2345,6 @@ private:
>         Value* x2 = nullptr;
>         Value* x3 = nullptr;
>         if (m_value->child(0)->opcode() == Mul && m_value->child(1)->opcode() == Mul) {
>-            Value* x1 = nullptr;
>-            Value* x2 = nullptr;
>-            Value* x3 = nullptr;
>             if (m_value->child(0)->child(0) == m_value->child(1)->child(0)) {
>                 // Op(Mul(x1, x2), Mul(x1, x3))
>                 x1 = m_value->child(0)->child(0);

Actions: View | Formatted Diff | Diff

Attachments on bug 196325: 366127 | 366325 | 366326 | 366767