Attachment 364213 Details for Bug 195537 – Patch

[patch] Patch

bug-195537-20190311014507.patch (text/plain), 1.31 KB, created by Guy Lewin on 2019-03-10 16:45:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Guy Lewin

Created: 2019-03-10 16:45:08 PDT

Size: 1.31 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 242689)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-03-10  Guy Lewin  <guy@lewin.co.il>
>+
>+        File input elements display icon with an empty file list after resetting the file list in
>+	'change' event handler - on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=195537
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No tests can be added because choosing files has to be done manually.
>+	Tests for this test already exist - under
>+	LayoutTests/fast/forms/file/file-input-reset*.html. Running them on
>+	iOS will show the error and will now be fixed.
>+
>+        * html/FileInputType.cpp:
>+        (WebCore::FileInputType::filesChosen):
>+
> 2019-03-10  Zalan Bujtas  <zalan@apple.com>
> 
>         [ContentChangeObserver] Fix failing test cases
>Index: Source/WebCore/html/FileInputType.cpp
>===================================================================
>--- Source/WebCore/html/FileInputType.cpp	(revision 242685)
>+++ Source/WebCore/html/FileInputType.cpp	(working copy)
>@@ -419,7 +419,7 @@ void FileInputType::filesChosen(const Ve
>         m_fileListCreator = nullptr;
>     });
> 
>-    if (icon)
>+    if (icon && (m_fileList->length() > 0))
>         iconLoaded(icon);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 195537: 364210 | 364212 | 364213 | 364214 | 366952 | 366975 | 366978