Attachment 352611 Details for Bug 190678 – Patch

[patch] Patch

bug-190678-20181017162141.patch (text/plain), 4.50 KB, created by Thibault Saunier on 2018-10-17 12:21:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-10-17 12:21:42 PDT

Size: 4.50 KB

patch

obsolete

>Subversion Revision: 237220
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ae7d53961c87bebfd8c316794db3a445122040f9..1d277515e3cc4ef183f2a323d01626db612c8f06 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-10-17  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer][WebRTC] Error out when simulcast is activated
>+        https://bugs.webkit.org/show_bug.cgi?id=190678
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implementing it is not for now yet.
>+
>+        Tests for simulcast have been disabled as they now fail (instead of crashing).
>+
>+        * platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
>+        (WebCore::GStreamerVideoEncoder::InitEncode):
>+
> 2018-10-17  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [GStreamer] Do not sync libwerbtc stream on the clock
>diff --git a/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp b/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp
>index 51e83506b6cc6daa083abc8a6be7de5eb514f11d..d58f3e56d2d8be80e62cb1b119fb9e89cd41f754 100644
>--- a/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp
>+++ b/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp
>@@ -31,6 +31,7 @@
> #include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
> #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
> #include "webrtc/modules/video_coding/include/video_codec_interface.h"
>+#include "webrtc/modules/video_coding/utility/simulcast_utility.h"
> 
> #include <gst/app/gstappsink.h>
> #include <gst/app/gstappsrc.h>
>@@ -106,6 +107,12 @@ public:
>         g_return_val_if_fail(codecSettings, WEBRTC_VIDEO_CODEC_ERR_PARAMETER);
>         g_return_val_if_fail(codecSettings->codecType == CodecType(), WEBRTC_VIDEO_CODEC_ERR_PARAMETER);
> 
>+        if (webrtc::SimulcastUtility::NumberOfSimulcastStreams(*codecSettings) > 1) {
>+            GST_ERROR("Simulcast not supported.");
>+
>+            return WEBRTC_VIDEO_CODEC_ERR_SIMULCAST_PARAMETERS_NOT_SUPPORTED;
>+        }
>+
>         m_encodedFrame._size = codecSettings->width * codecSettings->height * 3;
>         m_encodedFrame._buffer = new uint8_t[m_encodedFrame._size];
>         m_encodedImageBuffer.reset(m_encodedFrame._buffer);
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4410f20fad709d06082bac0be357f16544a7aa16..60f9b77cabd270c579c5190e0202c5dfe03a4aea 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-10-17  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer][WebRTC] Error out when simulcast is activated
>+        https://bugs.webkit.org/show_bug.cgi?id=190678
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implementing it is not for now yet.
>+        Tests for simulcast have been disabled as they now fail (instead of crashing).
>+
>+        * platform/gtk/TestExpectations:
>+        * platform/wpe/TestExpectations:
>+
> 2018-10-17  Ali Juma  <ajuma@chromium.org>
> 
>         Flaky IntersectionObserver web platform tests involving style updates
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 2816004a55f38dd734c420fb8395a543c604a6e3..89c09af776b78f13cf1e33443417f452876a6ba3 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -572,6 +572,7 @@ webkit.org/b/99036 fast/shadow-dom/pointerlockelement-in-slot.html [ Skip ]
> webkit.org/b/85211 ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm [ ImageOnlyFailure ]
> webkit.org/b/85212 ietestcenter/css3/flexbox/flexbox-layout-002.htm [ ImageOnlyFailure ]
> 
>+webkit.org/b/187064 webrtc/simulcast-h264.html
> webkit.org/b/187064 webrtc/audio-peer-connection-g722.html
> webkit.org/b/187064 webrtc/video-with-receiver.html
> webkit.org/b/187064 webrtc/captureCanvas-webrtc.html
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 2592dfed0255ec3df01e6dfe58032e19ee833023..61ff801ab97346abbc24f727559b2970cbb81087 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -46,6 +46,7 @@
> #////////////////////////////////////////////////////////////////////////////////////////
> 
> # The webrtc implementation is not fully completed yet
>+webkit.org/b/187064 webrtc/simulcast-h264.html
> webkit.org/b/189567 webrtc/video-addLegacyTransceiver.html [ Failure ]
> webkit.org/b/187064 webrtc/audio-peer-connection-g722.html
> webkit.org/b/187064 webrtc/video-with-receiver.html

Actions: View | Formatted Diff | Diff

Attachments on bug 190678: 352610 | 352611 | 353862