Attachment 351731 Details for Bug 190250 – WebKit part

[patch] WebKit part

file_190250.txt (text/plain), 18.55 KB, created by mitz on 2018-10-06 15:57:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2018-10-06 15:57:54 PDT

Size: 18.55 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 236900)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,32 @@
>+2018-10-06  Dan Bernstein  <mitz@apple.com>
>+
>+        WebKit part of [Xcode] Update some build settings as recommended by Xcode 10
>+        https://bugs.webkit.org/show_bug.cgi?id=190250
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
>+          CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
>+          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
>+
>+        * WebKit.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
>+
>+        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
>+        * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
>+        * UIProcess/API/Cocoa/WKConnection.mm:
>+        * UIProcess/API/Cocoa/WKNavigationData.mm:
>+        * UIProcess/API/Cocoa/WKProcessGroup.mm:
>+        * UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
>+        * UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
>+        * UIProcess/API/mac/WKView.mm:
>+        * WebProcess/Plugins/PDF/PDFPlugin.mm:
>+        * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
>+
>+          Suppressed -Wdeprecated-implementations around some class, category and method
>+          implementations the above files.
>+
> 2018-10-05  Alex Christensen  <achristensen@webkit.org>
> 
>         REGRESSION(r236154) Page loads are not drawn when loaded in shipped Safari11/12
>Index: Source/WebKit/Configurations/Base.xcconfig
>===================================================================
>--- Source/WebKit/Configurations/Base.xcconfig	(revision 236900)
>+++ Source/WebKit/Configurations/Base.xcconfig	(working copy)
>@@ -35,6 +35,7 @@ CLANG_CXX_LIBRARY = libc++;
> CLANG_ENABLE_OBJC_WEAK = YES;
> CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
> CLANG_WARN_BOOL_CONVERSION = YES;
>+CLANG_WARN_COMMA = YES;
> CLANG_WARN_CONSTANT_CONVERSION = YES;
> CLANG_WARN_CXX0X_EXTENSIONS = NO;
> CLANG_WARN_EMPTY_BODY = YES;
>@@ -74,8 +75,11 @@ GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
> GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
> GCC_WARN_ABOUT_RETURN_TYPE = YES;
> GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
>+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
> GCC_WARN_SIGN_COMPARE = YES;
> GCC_WARN_UNDECLARED_SELECTOR = YES;
>+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
>+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
> GCC_WARN_UNINITIALIZED_AUTOS = YES;
> GCC_WARN_UNUSED_FUNCTION = YES;
> GCC_WARN_UNUSED_VARIABLE = YES;
>Index: Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm	(working copy)
>@@ -72,7 +72,9 @@ NSString * const WKActionFrameNameKey = 
> NSString * const WKActionOriginatingFrameURLKey = @"WKActionOriginatingFrameURLKey";
> NSString * const WKActionCanShowMIMETypeKey = @"WKActionCanShowMIMETypeKey";
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKBrowsingContextController {
>+IGNORE_WARNINGS_END
>     RefPtr<WebKit::WebPageProxy> _page;
>     std::unique_ptr<WebKit::PageLoadStateObserver> _pageLoadStateObserver;
> 
>@@ -618,7 +620,9 @@ + (WKBrowsingContextController *)_browsi
> @end
> 
> ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKBrowsingContextController (Private)
>+IGNORE_WARNINGS_END
> 
> - (WKPageRef)_pageRef
> {
>Index: Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm	(working copy)
>@@ -42,7 +42,9 @@
> #import "WKURLCF.h"
> #import <wtf/Vector.h>
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKBrowsingContextGroup {
>+IGNORE_WARNINGS_END
>     API::ObjectStorage<WebKit::WebPageGroup> _pageGroup;
> }
> 
>@@ -176,7 +178,9 @@ - (API::Object&)_apiObject
> @end
> 
> ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKBrowsingContextGroup (Private)
>+IGNORE_WARNINGS_END
> 
> - (WKPageGroupRef)_pageGroupRef
> {
>Index: Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm	(working copy)
>@@ -36,7 +36,9 @@
> #import <wtf/WeakObjCPtr.h>
> #import <wtf/text/WTFString.h>
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKConnection {
>+IGNORE_WARNINGS_END
>     WeakObjCPtr<id <WKConnectionDelegate>> _delegate;
> }
> 
>Index: Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm	(working copy)
>@@ -32,7 +32,9 @@
> #import <WebCore/ResourceRequest.h>
> #import <WebCore/ResourceResponse.h>
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKNavigationData {
>+IGNORE_WARNINGS_END
>     API::ObjectStorage<API::NavigationData> _data;
> }
> 
>Index: Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm	(working copy)
>@@ -52,7 +52,9 @@
> #import <WebCore/WebCoreThreadSystemInterface.h>
> #endif
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKProcessGroup {
>+IGNORE_WARNINGS_END
>     RefPtr<WebKit::WebProcessPool> _processPool;
> 
>     WeakObjCPtr<id <WKProcessGroupDelegate>> _delegate;
>@@ -220,7 +222,9 @@ - (void)setDelegate:(id <WKProcessGroupD
> @end
> 
> ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKProcessGroup (Private)
>+IGNORE_WARNINGS_END
> 
> - (WKContextRef)_contextRef
> {
>Index: Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm	(working copy)
>@@ -36,7 +36,9 @@ @interface WKTypeRefWrapper () {
> }
> @end
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKTypeRefWrapper
>+IGNORE_WARNINGS_END
> 
> - (id)initWithObject:(WKTypeRef)object
> {
>Index: Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	(working copy)
>@@ -3295,7 +3295,9 @@ - (void)setFrameSize:(NSSize)size
>     _impl->setFrameSize(NSSizeToCGSize(size));
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)renewGState
>+IGNORE_WARNINGS_END
> {
>     _impl->renewGState();
>     [super renewGState];
>@@ -3789,7 +3791,9 @@ - (NSArray *)validAttributesForMarkedTex
> }
> 
> #if ENABLE(DRAG_SUPPORT)
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
>+IGNORE_WARNINGS_END
> {
>     _impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
> }
>@@ -3880,7 +3884,9 @@ - (id)accessibilityFocusedUIElement
>     return _impl->accessibilityFocusedUIElement();
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (BOOL)accessibilityIsIgnored
>+IGNORE_WARNINGS_END
> {
>     return _impl->accessibilityIsIgnored();
> }
>@@ -3890,7 +3896,9 @@ - (id)accessibilityHitTest:(NSPoint)poin
>     return _impl->accessibilityHitTest(NSPointToCGPoint(point));
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (id)accessibilityAttributeValue:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     return _impl->accessibilityAttributeValue(attribute);
> }
>@@ -3960,7 +3968,9 @@ - (void)pasteboard:(NSPasteboard *)paste
>     _impl->provideDataForPasteboard(pasteboard, type);
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
>+IGNORE_WARNINGS_END
> {
>     return _impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
> }
>Index: Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	(working copy)
>@@ -502,12 +502,16 @@ - (id <WKURLSchemeHandler>)urlSchemeHand
> 
> ALLOW_DEPRECATED_DECLARATIONS_BEGIN
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (_WKWebsiteDataStore *)_websiteDataStore
>+IGNORE_WARNINGS_END
> {
>     return self.websiteDataStore ? adoptNS([[_WKWebsiteDataStore alloc] initWithDataStore:self.websiteDataStore]).autorelease() : nullptr;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)_setWebsiteDataStore:(_WKWebsiteDataStore *)websiteDataStore
>+IGNORE_WARNINGS_END
> {
>     self.websiteDataStore = websiteDataStore ? websiteDataStore->_dataStore.get() : nullptr;
> }
>Index: Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm	(working copy)
>@@ -42,7 +42,9 @@ typedef NS_OPTIONS(NSUInteger, _WKWebsit
> 
> ALLOW_DEPRECATED_DECLARATIONS_BEGIN
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation _WKWebsiteDataStore
>+IGNORE_WARNINGS_END
> 
> - (instancetype)initWithDataStore:(WKWebsiteDataStore *)dataStore
> {
>Index: Source/WebKit/UIProcess/API/mac/WKView.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/mac/WKView.mm	(revision 236900)
>+++ Source/WebKit/UIProcess/API/mac/WKView.mm	(working copy)
>@@ -70,7 +70,9 @@ @interface WKView () <NSFilePromiseProvi
> 
> #endif
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKView
>+IGNORE_WARNINGS_END
> 
> #if WK_API_ENABLED
> 
>@@ -180,7 +182,9 @@ - (void)setFrameSize:(NSSize)size
>     _data->_impl->setFrameSize(NSSizeToCGSize(size));
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)renewGState
>+IGNORE_WARNINGS_END
> {
>     _data->_impl->renewGState();
>     [super renewGState];
>@@ -693,7 +697,9 @@ - (NSArray *)validAttributesForMarkedTex
> }
> 
> #if ENABLE(DRAG_SUPPORT)
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
>+IGNORE_WARNINGS_END
> {
>     _data->_impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
> }
>@@ -784,7 +790,9 @@ - (id)accessibilityFocusedUIElement
>     return _data->_impl->accessibilityFocusedUIElement();
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (BOOL)accessibilityIsIgnored
>+IGNORE_WARNINGS_END
> {
>     return _data->_impl->accessibilityIsIgnored();
> }
>@@ -794,7 +802,9 @@ - (id)accessibilityHitTest:(NSPoint)poin
>     return _data->_impl->accessibilityHitTest(NSPointToCGPoint(point));
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (id)accessibilityAttributeValue:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     return _data->_impl->accessibilityAttributeValue(attribute);
> }
>@@ -864,7 +874,9 @@ - (void)pasteboard:(NSPasteboard *)paste
>     _data->_impl->provideDataForPasteboard(pasteboard, type);
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
>+IGNORE_WARNINGS_END
> {
>     return _data->_impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
> }
>@@ -1121,7 +1133,9 @@ - (void)draggingSession:(NSDraggingSessi
> @end
> 
> ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> @implementation WKView (Private)
>+IGNORE_WARNINGS_END
> 
> - (void)saveBackForwardSnapshotForCurrentItem
> {
>Index: Source/WebKit/WebKit.xcodeproj/project.pbxproj
>===================================================================
>--- Source/WebKit/WebKit.xcodeproj/project.pbxproj	(revision 236900)
>+++ Source/WebKit/WebKit.xcodeproj/project.pbxproj	(working copy)
>@@ -9984,7 +9984,7 @@
> 			isa = PBXProject;
> 			attributes = {
> 				LastSwiftUpdateCheck = 0700;
>-				LastUpgradeCheck = 0700;
>+				LastUpgradeCheck = 1000;
> 				TargetAttributes = {
> 					E1AC2E2720F7B94C00B0897D = {
> 						CreatedOnToolsVersion = 9.3;
>Index: Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
>===================================================================
>--- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm	(revision 236900)
>+++ Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm	(working copy)
>@@ -161,7 +161,9 @@ - (void)setPdfLayerController:(PDFLayerC
> #endif
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (BOOL)accessibilityIsIgnored
>+IGNORE_WARNINGS_END
> {
>     return NO;
> }
>@@ -172,7 +174,9 @@ - (NSRect)convertRectToScreenSpace:(NSRe
>     return _pdfPlugin->convertFromPDFViewToScreen(rect);
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (id)accessibilityAttributeValue:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     if ([attribute isEqualToString:NSAccessibilityParentAttribute])
>         return _parent;
>@@ -214,7 +218,9 @@ - (id)accessibilityAttributeValue:(NSStr
>     return 0;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
>+IGNORE_WARNINGS_END
> {
>     if ([attribute isEqualToString:NSAccessibilityBoundsForRangeParameterizedAttribute]) {
>         NSRect boundsInPDFViewCoordinates = [[_pdfLayerController accessibilityBoundsForRangeAttributeForParameter:parameter] rectValue];
>@@ -237,7 +243,9 @@ - (CPReadingModel *)readingModel
>     return [_pdfLayerController readingModel];
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)accessibilityAttributeNames
>+IGNORE_WARNINGS_END
> {
>     static NSArray *attributeNames = 0;
> 
>@@ -269,7 +277,9 @@ - (NSArray *)accessibilityAttributeNames
>     return attributeNames;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)accessibilityActionNames
>+IGNORE_WARNINGS_END
> {
> #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
>     return nil;
>@@ -283,23 +293,31 @@ - (NSArray *)accessibilityActionNames
> #endif
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)accessibilityPerformAction:(NSString *)action
>+IGNORE_WARNINGS_END
> {
>     if ([action isEqualToString:NSAccessibilityShowMenuAction])
>         _pdfPlugin->showContextMenuAtPoint(WebCore::IntRect(WebCore::IntPoint(), _pdfPlugin->size()).center());
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     return [_pdfLayerController accessibilityIsAttributeSettable:attribute];
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     return [_pdfLayerController accessibilitySetValue:value forAttribute:attribute];
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)accessibilityParameterizedAttributeNames
>+IGNORE_WARNINGS_END
> {
> #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
>     return nil;
>Index: Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm	(revision 236900)
>+++ Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm	(working copy)
>@@ -60,12 +60,16 @@ - (void)dealloc
>     [super dealloc];
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (BOOL)accessibilityIsIgnored
>+IGNORE_WARNINGS_END
> {
>     return NO;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)accessibilityAttributeNames
>+IGNORE_WARNINGS_END
> {
>     if (!m_attributeNames)
>         m_attributeNames = adoptNS([[NSArray alloc] initWithObjects:
>@@ -76,7 +80,9 @@ - (NSArray *)accessibilityAttributeNames
>     return m_attributeNames.get();
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)accessibilityParameterizedAttributeNames
>+IGNORE_WARNINGS_END
> {
>     Vector<String> result = m_page->corePage()->pageOverlayController().copyAccessibilityAttributesNames(true);
>     if (result.isEmpty())
>@@ -89,12 +95,16 @@ - (NSArray *)accessibilityParameterizedA
>     return names;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     return NO;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
> }
> 
>@@ -103,7 +113,9 @@ - (NSPoint)convertScreenPointToRootView:
>     return m_page->screenToRootView(IntPoint(point.x, point.y));
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (NSArray *)accessibilityActionNames
>+IGNORE_WARNINGS_END
> {
>     return [NSArray array];
> }
>@@ -117,7 +129,9 @@ - (NSArray *)accessibilityChildren
>     return [NSArray arrayWithObject:wrapper];
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (id)accessibilityAttributeValue:(NSString *)attribute
>+IGNORE_WARNINGS_END
> {
>     if (!WebCore::AXObjectCache::accessibilityEnabled())
>         WebCore::AXObjectCache::enableAccessibility();
>@@ -162,7 +176,9 @@ - (id)accessibilityAttributeValue:(NSStr
>     return nil;
> }
> 
>+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
> - (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
>+IGNORE_WARNINGS_END
> {
>     WebCore::FloatPoint pageOverlayPoint;
>     if ([parameter isKindOfClass:[NSValue class]] && !strcmp([(NSValue *)parameter objCType], @encode(NSPoint)))

Actions: View | Formatted Diff | Diff

Attachments on bug 190250: 351527 | 351545 | 351556 | 351558 | 351589 | 351652 | 351731 | 351732 | 351733 | 351748