Attachment 332443 Details for Bug 182204 – Patch

[patch] Patch

bug-182204-20180126175515.patch (text/plain), 3.36 KB, created by Megan Gardner on 2018-01-26 17:55:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-01-26 17:55:15 PST

Size: 3.36 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 227709)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-01-26  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Don't retain focus for input peripheral views
>+        https://bugs.webkit.org/show_bug.cgi?id=182204
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Retaining focus on input peripheral views makes it so they cannot dismiss themselves with
>+        the current architecture. This should probably be fixed in UIKit, as there is no reason for
>+        focus to be retains on these views anyways, as they don't have keyboard input, but this
>+        guards against over-aggressive retain requests.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _restoreFocusWithToken:]):
>+        (-[WKContentView _preserveFocusWithToken:destructively:]):
>+
> 2018-01-26  Chris Dumez  <cdumez@apple.com>
> 
>         Make sure service worker code does not launch a StorageProcess unnecessarily
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 227377)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -4169,12 +4169,14 @@ - (void)fileUploadPanelDidDismiss:(WKFil
> 
> - (void)_restoreFocusWithToken:(id <NSCopying, NSSecureCoding>)token
> {
>-    --_webView->_activeFocusedStateRetainCount;
>+    if (!_inputPeripheral)
>+        --_webView->_activeFocusedStateRetainCount;
> }
> 
> - (void)_preserveFocusWithToken:(id <NSCopying, NSSecureCoding>)token destructively:(BOOL)destructively
> {
>-    ++_webView->_activeFocusedStateRetainCount;
>+    if (!_inputPeripheral)
>+        ++_webView->_activeFocusedStateRetainCount;
> }
> 
> #pragma mark - Implementation of UIWebTouchEventsGestureRecognizerDelegate.
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 227376)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-01-26  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Don't retain focus for input peripheral views
>+        https://bugs.webkit.org/show_bug.cgi?id=182204
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fixed a spelling error while fixing a bug this test caught.
>+
>+        * fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html:
>+
> 2018-01-22  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (r226981): ASSERTION FAILED: startY >= 0 && endY <= height && startY < endY in WebCore::FEMorphology::platformApplyGeneric
>Index: LayoutTests/fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html
>===================================================================
>--- LayoutTests/fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html	(revision 227376)
>+++ LayoutTests/fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html	(working copy)
>@@ -76,7 +76,7 @@
>         var clicked = false;
>         function buttonClicked()
>         {
>-            document.getElementById('result').textContent = 'PASS: hit testing found #target after select interation';
>+            document.getElementById('result').textContent = 'PASS: hit testing found #target after select interaction';
>             if (window.testRunner)
>                 testRunner.notifyDone();
>         }

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 182204: 332443