WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-181162-20171226180118.patch (text/plain), 1.87 KB, created by
Zan Dobersek
on 2017-12-26 09:01:19 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Zan Dobersek
Created:
2017-12-26 09:01:19 PST
Size:
1.87 KB
patch
obsolete
>Subversion Revision: 226292 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 5f9ab0265adebca3a7f3574d6aaef05646973172..d0e0532e8e8bb5be17bb62529e86cf33dac5e927 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,18 @@ >+2017-12-26 Zan Dobersek <zdobersek@igalia.com> >+ >+ REGRESSION(r225913): about 30 JSC test failures on ARMv7 >+ https://bugs.webkit.org/show_bug.cgi?id=181162 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fast case in DFG::SpeculativeJIT::compileArraySlice() was enabled in >+ r225913 on all but 32-bit x86 platform. Other 32-bit platforms have the >+ same lack of GP registers, so the conditional is changed here to only >+ enable this optimization explicitly on ARM64 and x86-64. >+ >+ * dfg/DFGSpeculativeJIT.cpp: >+ (JSC::DFG::SpeculativeJIT::compileArraySlice): >+ > 2017-12-22 Caio Lima <ticaiolima@gmail.com> > > [JSC] IntlCollator and IntlNumberFormat has static fields with same name >diff --git a/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp b/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp >index d6674748631cafa5a229ef0753e5cbf220e055d6..8e7b63e91375bd6771f5ac7db99edf35b0b8d5e5 100644 >--- a/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp >+++ b/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp >@@ -7635,7 +7635,7 @@ void SpeculativeJIT::compileArraySlice(Node* node) > MacroAssembler::JumpList slowCases; > m_jit.move(TrustedImmPtr(0), storageResultGPR); > // X86 only has 6 GP registers, which is not enough for the fast case here. At least without custom code, which is not currently worth the extra code maintenance. >- if (!isX86() || isX86_64()) { >+ if (isARM64() || isX86_64()) { > GPRTemporary scratch(this); > GPRTemporary scratch2(this); > GPRTemporary indexingMask(this);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 181162
: 330195 |
330199