Attachment 317079 Details for Bug 175113 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

eliminate-leaks-1.patch (text/plain), 1.18 KB, created by Joseph Pecoraro on 2017-08-02 20:36:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2017-08-02 20:36:51 PDT

Size: 1.18 KB

patch

obsolete

>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index d5f02abed69..8519ba9765a 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2017-08-02  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        NeverDestroyed related leaks seen on bots
>+        https://bugs.webkit.org/show_bug.cgi?id=175113
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/NeverDestroyed.h:
>+        (WTF::NeverDestroyed::NeverDestroyed):
>+        Adding a move constructor convinces the compiler to move the result
>+        of makeNeverDestroyed into the NeverDestroyed static.
>+
> 2017-07-31  Matt Lewis  <jlewis3@apple.com>
> 
>         Unreviewed, rolling out r220060.
>diff --git a/Source/WTF/wtf/NeverDestroyed.h b/Source/WTF/wtf/NeverDestroyed.h
>index 8784b6ed650..c2b4842d12d 100644
>--- a/Source/WTF/wtf/NeverDestroyed.h
>+++ b/Source/WTF/wtf/NeverDestroyed.h
>@@ -50,6 +50,11 @@ public:
>         MaybeRelax<T>(new (storagePointer()) T(std::forward<Args>(args)...));
>     }
> 
>+    NeverDestroyed(NeverDestroyed&& other)
>+    {
>+        MaybeRelax<T>(new (storagePointer()) T(WTFMove(other)));
>+    }
>+
>     operator T&() { return *storagePointer(); }
>     T& get() { return *storagePointer(); }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 175113: 317079 | 317083