Attachment 309091 Details for Bug 171683 – Patch

[patch] Patch

bug-171683-20170504124756.patch (text/plain), 3.67 KB, created by Chris Dumez on 2017-05-04 12:47:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2017-05-04 12:47:57 PDT

Size: 3.67 KB

patch

obsolete

>Subversion Revision: 216198
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7bc3435551464a7443017c5c39373844ae75d945..606fa9d680d79f5d3b96ff082b730c2c9de40547 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2017-05-04  Chris Dumez  <cdumez@apple.com>
>+
>+        Element.slot should be marked as [Unscopable]
>+        https://bugs.webkit.org/show_bug.cgi?id=171683
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Element.slot should be marked as [Unscopable]:
>+        - https://dom.spec.whatwg.org/#interface-element
>+        - https://heycam.github.io/webidl/#Unscopable
>+
>+        Test: fast/shadow-dom/Element-slot-unscopable.html
>+
>+        * dom/Element.idl:
>+
> 2017-05-04  Sam Weinig  <sam@webkit.org>
> 
>         Make the [EnabledBySetting] extended attribute work for any attribute or operation on a prototype
>diff --git a/Source/WebCore/dom/Element.idl b/Source/WebCore/dom/Element.idl
>index 9342b5a9c42ce12787aada8a4201684c58cd8e82..ac82e355463764e08690f9b2690db2fb4c7f2021 100644
>--- a/Source/WebCore/dom/Element.idl
>+++ b/Source/WebCore/dom/Element.idl
>@@ -132,7 +132,7 @@
>     // Shadow DOM API
>     [EnabledAtRuntime=ShadowDOM, MayThrowException] ShadowRoot attachShadow(ShadowRootInit init);
>     [EnabledAtRuntime=ShadowDOM, ImplementedAs=shadowRootForBindings, CallWith=ScriptState] readonly attribute ShadowRoot shadowRoot;
>-    [CEReactions, EnabledAtRuntime=ShadowDOM, Reflect] attribute DOMString slot;
>+    [CEReactions, EnabledAtRuntime=ShadowDOM, Reflect, Unscopable] attribute DOMString slot;
> 
>     // Event Handlers
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 49733b97d03e8e460b2d72db0804fc0cc7958e16..1661496da4fd07f786cd55264a2011d31f4aff52 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2017-05-04  Chris Dumez  <cdumez@apple.com>
>+
>+        Element.slot should be marked as [Unscopable]
>+        https://bugs.webkit.org/show_bug.cgi?id=171683
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add layout test coverage. This test is passing in Firefox and Chrome.
>+
>+        * fast/shadow-dom/Element-slot-unscopable-expected.txt: Added.
>+        * fast/shadow-dom/Element-slot-unscopable.html: Added.
>+
> 2017-05-04  Daniel Bates  <dabates@apple.com>
> 
>         importScripts() should respect X-Content-Type-Options: nosniff
>diff --git a/LayoutTests/fast/shadow-dom/Element-slot-unscopable-expected.txt b/LayoutTests/fast/shadow-dom/Element-slot-unscopable-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..2387734241f7d5e2323608229af31bc9dcb1bb9d
>--- /dev/null
>+++ b/LayoutTests/fast/shadow-dom/Element-slot-unscopable-expected.txt
>@@ -0,0 +1,10 @@
>+Tests that Element.slot is [Unscopable].
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+PASS exception.name is "ReferenceError"
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>diff --git a/LayoutTests/fast/shadow-dom/Element-slot-unscopable.html b/LayoutTests/fast/shadow-dom/Element-slot-unscopable.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..2281cdaf3c08806b89f6a1fa8989cc8980a1aac7
>--- /dev/null
>+++ b/LayoutTests/fast/shadow-dom/Element-slot-unscopable.html
>@@ -0,0 +1,20 @@
>+<!DOCTYPE html>
>+<html>
>+<body>
>+<script src="../../resources/js-test-pre.js"></script>
>+<script>
>+description("Tests that Element.slot is [Unscopable].");
>+
>+with (document.body) {
>+    try {
>+        slot;
>+        testFailed("Element.body is not [Unscopable]");
>+    } catch(e) {
>+        exception = e;
>+        shouldBeEqualToString("exception.name", "ReferenceError");
>+    }
>+}
>+</script>
>+<script src="../../resources/js-test-post.js"></script>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 171683: 309091