Attachment 304892 Details for Bug 169857 – proposed patch

[patch] proposed patch

WebResourceHandler.txt (text/plain), 1.42 KB, created by Alexey Proskuryakov on 2017-03-18 23:02:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2017-03-18 23:02:53 PDT

Size: 1.42 KB

patch

obsolete

>Index: Source/WebKit/mac/ChangeLog
>===================================================================
>--- Source/WebKit/mac/ChangeLog	(revision 214142)
>+++ Source/WebKit/mac/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2017-03-18  Alexey Proskuryakov  <ap@apple.com>
>+
>+        WebHTMLView is useless as WebResourceHandler
>+        https://bugs.webkit.org/show_bug.cgi?id=169857
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebView/WebHTMLView.mm:
>+        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
>+        WebHTMLView doesnt implement any of WebResourceHandler methods.
>+
> 2017-03-17  Michael Saboff  <msaboff@apple.com>
> 
>         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
>Index: Source/WebKit/mac/WebView/WebHTMLView.mm
>===================================================================
>--- Source/WebKit/mac/WebView/WebHTMLView.mm	(revision 214142)
>+++ Source/WebKit/mac/WebView/WebHTMLView.mm	(working copy)
>@@ -2554,7 +2554,7 @@ - (DOMDocumentFragment *)_documentFragme
>             
>         NSDictionary *documentAttributes = [[NSDictionary alloc] initWithObjectsAndKeys:
>             [[self class] _excludedElementsForAttributedStringConversion], NSExcludedElementsDocumentAttribute,
>-            self, @"WebResourceHandler", nil];
>+            nil];
>         NSArray *s;
>         
>         BOOL wasDeferringCallbacks = [[self _webView] defersCallbacks];

Actions: View | Formatted Diff | Diff

Attachments on bug 169857: 304892