Attachment 304741 Details for Bug 158100 – Patch

[patch] Patch

bug-158100-20170316210053.patch (text/plain), 2.60 KB, created by Devin Rousso on 2017-03-16 20:00:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2017-03-16 20:00:54 PDT

Size: 2.60 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d6000037c9b3d603389d2282db9e062f7914dce5..d2a42864e34a3935db80789ce4857eb89f824efb 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,5 +1,20 @@
> 2017-03-16  Devin Rousso  <webkit@devinrousso.com>
> 
>+        Web Inspector: memory category timelines would look better with ruler tick-aligned guides
>+        https://bugs.webkit.org/show_bug.cgi?id=158100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/MemoryTimelineView.css:
>+        (.timeline-view.memory > .content > .details):
>+        (.timeline-view.memory > .content > .details > .timeline-ruler):
>+        (body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler):
>+        (body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler):
>+        Make the TimelineRuler absolutely positioned so it can use the full height of the view,
>+        providing enough space for the markers to be visible.
>+
>+2017-03-16  Devin Rousso  <webkit@devinrousso.com>
>+
>         Web Inspector: Console Evaluation links in the Console should not show normally
>         https://bugs.webkit.org/show_bug.cgi?id=157483
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css b/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css
>index 9018b6f0ebfa9846555d217ad7d992a41b0ee664..6e642b3ec2209ac7660a98f38c0a7b2b730e6257 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css
>@@ -43,19 +43,26 @@
>     font-size: 14px;
> }
> 
>-.timeline-view.memory > .content > .details > .timeline-ruler {
>+.timeline-view.memory > .content > .details {
>     position: relative;
>+}
>+
>+.timeline-view.memory > .content > .details > .timeline-ruler {
>+    position: absolute;
>     top: 5px;
>+    bottom: 0;
>+    right: 0;
>+    left: 0;
> 
>-    --memory-timeline-view-details-timeline-ruler-margin-start: 150px;
>+    --memory-timeline-view-details-timeline-ruler-offset-start: 150px;
> }
> 
> body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler {
>-    margin-left: var(--memory-timeline-view-details-timeline-ruler-margin-start);
>+    left: var(--memory-timeline-view-details-timeline-ruler-offset-start);
> }
> 
> body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler {
>-    margin-right: var(--memory-timeline-view-details-timeline-ruler-margin-start);
>+    right: var(--memory-timeline-view-details-timeline-ruler-offset-start);
> }
> 
> .timeline-view.memory > .content > .details > .subtitle {

Actions: View | Formatted Diff | Diff

Attachments on bug 158100: 279837 | 304741 | 304742