Attachment 277421 Details for Bug 157051 – Patch

[patch] Patch

bug-157051-20160426163448.patch (text/plain), 1.54 KB, created by Alex Christensen on 2016-04-26 16:34:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2016-04-26 16:34:20 PDT

Size: 1.54 KB

patch

obsolete

>Index: Source/WebKit2/ChangeLog
>===================================================================
>--- Source/WebKit2/ChangeLog	(revision 200113)
>+++ Source/WebKit2/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2016-04-26  Alex Christensen  <achristensen@webkit.org>
>+
>+        Fix assertion when downloading with NSURLSession after r198955
>+        https://bugs.webkit.org/show_bug.cgi?id=157051
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/NetworkProcess.cpp:
>+        (WebKit::NetworkProcess::continueDecidePendingDownloadDestination):
>+
> 2016-04-26  Beth Dakin  <bdakin@apple.com>
> 
>         Check to make sure shouldRequestCandidates() before requesting candidates
>Index: Source/WebKit2/NetworkProcess/NetworkProcess.cpp
>===================================================================
>--- Source/WebKit2/NetworkProcess/NetworkProcess.cpp	(revision 200045)
>+++ Source/WebKit2/NetworkProcess/NetworkProcess.cpp	(working copy)
>@@ -523,7 +523,10 @@ void NetworkProcess::findPendingDownload
>     
> void NetworkProcess::continueDecidePendingDownloadDestination(DownloadID downloadID, String destination, const SandboxExtension::Handle& sandboxExtensionHandle, bool allowOverwrite)
> {
>-    downloadManager().continueDecidePendingDownloadDestination(downloadID, destination, sandboxExtensionHandle, allowOverwrite);
>+    if (destination.isEmpty())
>+        downloadManager().cancelDownload(downloadID);
>+    else
>+        downloadManager().continueDecidePendingDownloadDestination(downloadID, destination, sandboxExtensionHandle, allowOverwrite);
> }
> #endif
>

Actions: View | Formatted Diff | Diff

Attachments on bug 157051: 277421