Attachment 275185 Details for Bug 156010 – Patch

[patch] Patch

bug-156010-20160329224056.patch (text/plain), 2.26 KB, created by Benjamin Poulain on 2016-03-29 22:40:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Poulain

Created: 2016-03-29 22:40:53 PDT

Size: 2.26 KB

patch

obsolete

>Subversion Revision: 198827
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 0ab3f5c58ca0b0c8bb5c6a6d78ff2b9bbd082db9..2ffd1566f16be328622a1091117529cd1a640ec9 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
>+
>+        [JSC] Get rid of operationInitGlobalConst(), it is useless
>+        https://bugs.webkit.org/show_bug.cgi?id=156010
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * jit/JITOperations.cpp:
>+        * jit/JITOperations.h:
>+
> 2016-03-29  Saam barati  <sbarati@apple.com>
> 
>         Fix typos in our error messages and remove some trailing periods
>diff --git a/Source/JavaScriptCore/jit/JITOperations.cpp b/Source/JavaScriptCore/jit/JITOperations.cpp
>index efcabcd6458da53e69e57c54031d84863ce75ace..6037a0c7b237c8fdc1b1dca61d9a10f458125e76 100644
>--- a/Source/JavaScriptCore/jit/JITOperations.cpp
>+++ b/Source/JavaScriptCore/jit/JITOperations.cpp
>@@ -2002,15 +2002,6 @@ void JIT_OPERATION operationUnconditionalWriteBarrier(ExecState* exec, JSCell* c
>     vm->heap.writeBarrier(cell);
> }
> 
>-void JIT_OPERATION operationInitGlobalConst(ExecState* exec, Instruction* pc)
>-{
>-    VM* vm = &exec->vm();
>-    NativeCallFrameTracer tracer(vm, exec);
>-
>-    JSValue value = exec->r(pc[2].u.operand).jsValue();
>-    pc[1].u.variablePointer->set(*vm, exec->codeBlock()->globalObject(), value);
>-}
>-
> void JIT_OPERATION lookupExceptionHandler(VM* vm, ExecState* exec)
> {
>     NativeCallFrameTracer tracer(vm, exec);
>diff --git a/Source/JavaScriptCore/jit/JITOperations.h b/Source/JavaScriptCore/jit/JITOperations.h
>index d48732275adc71aadc8bf074aafceaf610421633..d49b3dd5dfc7386eefec17c4f72e08ec57a7f10b 100644
>--- a/Source/JavaScriptCore/jit/JITOperations.h
>+++ b/Source/JavaScriptCore/jit/JITOperations.h
>@@ -382,8 +382,6 @@ void JIT_OPERATION operationWriteBarrier(ExecState*, JSCell*, JSCell*);
> void JIT_OPERATION operationUnconditionalWriteBarrier(ExecState*, JSCell*);
> void JIT_OPERATION operationOSRWriteBarrier(ExecState*, JSCell*);
> 
>-void JIT_OPERATION operationInitGlobalConst(ExecState*, Instruction*);
>-
> void JIT_OPERATION operationExceptionFuzz(ExecState*);
> 
> int32_t JIT_OPERATION operationCheckIfExceptionIsUncatchableAndNotifyProfiler(ExecState*);

Actions: View | Formatted Diff | Diff

Attachments on bug 156010: 275185