Attachment 26539 Details for Bug 23024 – fix the crash for referencing deleted floating objects

[patch] fix the crash for referencing deleted floating objects

fix-floating-object (text/plain), 1.42 KB, created by Hin-Chung Lam on 2009-01-08 14:57:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Hin-Chung Lam

Created: 2009-01-08 14:57:40 PST

Size: 1.42 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 39698)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2009-01-07  Alpha Lam  <hclam@google.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+       https://bugs.webkit.org/show_bug.cgi?id=23024
>+
>+       Remove an incorrect criteria in the if statement that leaves references to deleted floating object in RenderBlock.
>+
>+        * rendering/RenderBlock.cpp:
>+        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
>+
> 2009-01-07  Chris Marrin  <cmarrin@apple.com>
> 
>         Reviewed by Eric Seidel.
>Index: WebCore/rendering/RenderBlock.cpp
>===================================================================
>--- WebCore/rendering/RenderBlock.cpp	(revision 39697)
>+++ WebCore/rendering/RenderBlock.cpp	(working copy)
>@@ -3036,7 +3036,7 @@ void RenderBlock::markAllDescendantsWith
>     // Iterate over our children and mark them as needed.
>     if (!childrenInline()) {
>         for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
>-            if (isBlockFlow() && !child->isFloatingOrPositioned() &&
>+            if (isBlockFlow() && !child->isFloating() &&
>                 ((floatToRemove ? child->containsFloat(floatToRemove) : child->containsFloats()) || child->shrinkToAvoidFloats()))
>                 child->markAllDescendantsWithFloatsForLayout(floatToRemove);
>         }

Flags:

darin: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 23024: 26337 | 26451 | 26521 | 26539 | 26809 | 26812 | 27501 | 27502 | 27504 | 27505 | 27507 | 27508 | 28335 | 28336 | 28347 | 28349 | 28350 | 28351 | 28352