Attachment 259564 Details for Bug 148273 – Patch

[patch] Patch

bug-148273-20150820192419.patch (text/plain), 8.65 KB, created by Yusuke Suzuki on 2015-08-20 19:24:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2015-08-20 19:24:24 PDT

Size: 8.65 KB

patch

obsolete

>Subversion Revision: 188724
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 0294946ff15b96f6dd7ac76909648f7a7bdcd3f2..d5232a94db7c6b3fabd0b3dbc357533602af2e2a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2015-08-20  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Skip no-llint tests that fail due to running out of executable memory after r188969
>+        https://bugs.webkit.org/show_bug.cgi?id=148273
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/run-jsc-stress-tests:
>+
> 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
> 
>         Unreviewed, changed Devin Rousso's email.
>diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests
>index 92bb3ce4b499322876c1f9aad6a195da88eb4f0f..f4e3e8f2e5b168b26674f3d1db581fc151e6da08 100755
>--- a/Tools/Scripts/run-jsc-stress-tests
>+++ b/Tools/Scripts/run-jsc-stress-tests
>@@ -930,6 +930,17 @@ def defaultRunLayoutTest
>     end
> end
> 
>+def noNoLLIntRunLayoutTest
>+    runLayoutTestDefault
>+    if $jitTests
>+        runLayoutTestNoCJIT
>+        runLayoutTestDFGEagerNoCJIT
>+        runLayoutTestDefaultFTL
>+        runLayoutTestFTLNoCJIT
>+        runLayoutTestFTLEagerNoCJIT
>+    end
>+end
>+
> def prepareExtraRelativeFiles(extraFiles, destination)
>     Dir.chdir($outputDir) {
>         extraFiles.each {
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 77c37ed5ece758e097f4529cc937ba4f22f311cc..0134eafdd76df1fddca6bac094eaa7f55e4c1740 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,26 @@
>+2015-08-20  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        Skip no-llint tests that fail due to running out of executable memory after r188969
>+        https://bugs.webkit.org/show_bug.cgi?id=148273
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        After r188969, put_by_val operation also generates chained IC like put_by_id.
>+        It consumes much memory and when no-llint, some tests failed due to "ran out of executable memory".
>+        This patch temporary skips failing tests.
>+
>+        * js/script-tests/dfg-float32array.js:
>+        * js/script-tests/dfg-int16array.js:
>+        * js/script-tests/dfg-int32array-overflow-values.js:
>+        * js/script-tests/dfg-int32array.js:
>+        * js/script-tests/dfg-int8array.js:
>+        * js/script-tests/dfg-uint16array.js:
>+        * js/script-tests/dfg-uint32array-overflow-values.js:
>+        * js/script-tests/dfg-uint32array.js:
>+        * js/script-tests/dfg-uint8array.js:
>+        * js/script-tests/dfg-uint8clampedarray.js:
>+        * js/script-tests/regress-141098.js:
>+
> 2015-08-20  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         Test gardening after r188167
>diff --git a/LayoutTests/js/script-tests/dfg-float32array.js b/LayoutTests/js/script-tests/dfg-float32array.js
>index 98cbd3b518dbd4d2af779d082c8673c16e951ba2..d8c3ebdb5f30b313dbe5d7990526cea36fab2b01 100644
>--- a/LayoutTests/js/script-tests/dfg-float32array.js
>+++ b/LayoutTests/js/script-tests/dfg-float32array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that float32 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-int16array.js b/LayoutTests/js/script-tests/dfg-int16array.js
>index 0c403b8341975ff5023cd3e365f8ede84115b311..acc1a4fa8bfe58bd4111c81d728f84f06740ac10 100644
>--- a/LayoutTests/js/script-tests/dfg-int16array.js
>+++ b/LayoutTests/js/script-tests/dfg-int16array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that int16 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js b/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
>index 781359c5b53ff8c5025ba2b3436d0015aa30aeaf..2f4812302d24541be0aba52871ced96f2bc4add9 100644
>--- a/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
>+++ b/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that int32 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-int32array.js b/LayoutTests/js/script-tests/dfg-int32array.js
>index c49a452ac989216a885eb96d6d250f362a8f5ac1..1dad166ad2f292650ab08550b2d5e1b34f927473 100644
>--- a/LayoutTests/js/script-tests/dfg-int32array.js
>+++ b/LayoutTests/js/script-tests/dfg-int32array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that int32 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-int8array.js b/LayoutTests/js/script-tests/dfg-int8array.js
>index ee502234b673b0db9d5b5e576bdcd8f241f419fc..45d0dc303a5db4c1560193b92076d37d81a63727 100644
>--- a/LayoutTests/js/script-tests/dfg-int8array.js
>+++ b/LayoutTests/js/script-tests/dfg-int8array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that int8 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-uint16array.js b/LayoutTests/js/script-tests/dfg-uint16array.js
>index ec56629b7ea82b69d6c11dd7da7327dd26d039b3..36fdffc70cae13d5049324cf67a6ec67fd3d113f 100644
>--- a/LayoutTests/js/script-tests/dfg-uint16array.js
>+++ b/LayoutTests/js/script-tests/dfg-uint16array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that uint16 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-uint32array-overflow-values.js b/LayoutTests/js/script-tests/dfg-uint32array-overflow-values.js
>index 588147cc40c5ae46a610a104bd7328afa9ba4a9d..eeab341eb6d9513d9af590cfa253092c9acea516 100644
>--- a/LayoutTests/js/script-tests/dfg-uint32array-overflow-values.js
>+++ b/LayoutTests/js/script-tests/dfg-uint32array-overflow-values.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that int32 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-uint32array.js b/LayoutTests/js/script-tests/dfg-uint32array.js
>index abd4643ef433bbdbdb8fd78b2b2e038358b535d6..1d9941a459855e9d1134da40d0a4312a74a3a231 100644
>--- a/LayoutTests/js/script-tests/dfg-uint32array.js
>+++ b/LayoutTests/js/script-tests/dfg-uint32array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that uint32 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-uint8array.js b/LayoutTests/js/script-tests/dfg-uint8array.js
>index cc014d1cc64736c71c3fcb8270eb8a4d9cf07b60..0fd7f45961d47b559d56f570ea7ba5ad4d8355af 100644
>--- a/LayoutTests/js/script-tests/dfg-uint8array.js
>+++ b/LayoutTests/js/script-tests/dfg-uint8array.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that uint8 arrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/dfg-uint8clampedarray.js b/LayoutTests/js/script-tests/dfg-uint8clampedarray.js
>index 42b0a517b7b1cbd9b5f41280695ac4643eaafb45..1ba3ad7b7bba2ae047609a4503c74b349dbeeddb 100644
>--- a/LayoutTests/js/script-tests/dfg-uint8clampedarray.js
>+++ b/LayoutTests/js/script-tests/dfg-uint8clampedarray.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description(
> "This tests that Uint8ClampedArrays work in the DFG."
> );
>diff --git a/LayoutTests/js/script-tests/regress-141098.js b/LayoutTests/js/script-tests/regress-141098.js
>index bf434d12dd5906fd41cb45949f15f7383e3ea0a2..23142777dfe23618c6a195e8bbba5dfdd1fddf54 100644
>--- a/LayoutTests/js/script-tests/regress-141098.js
>+++ b/LayoutTests/js/script-tests/regress-141098.js
>@@ -1,3 +1,6 @@
>+// put_by_val IC uses more executable memory than before.
>+// https://bugs.webkit.org/show_bug.cgi?id=148273
>+//@ noNoLLIntRunLayoutTest
> description("Regression test for https://webkit.org/b/141098. Make sure eval() properly handles running out of stack space. This test should run without crashing.");
> 
> // The tiering up to test higher levels of optimization will only test the DFG

Actions: View | Formatted Diff | Diff

Attachments on bug 148273: 259564 | 259572 | 259585 | 259634