Attachment 256576 Details for Bug 146833 – Patch

[patch] Patch

bug-146833-20150710035601.patch (text/plain), 4.57 KB, created by Csaba Osztrogonác on 2015-07-10 03:57:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Csaba Osztrogonác

Created: 2015-07-10 03:57:03 PDT

Size: 4.57 KB

patch

obsolete

>Subversion Revision: 186667
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 0e02a05912d044a55b6720dba4033adff0a80953..e26cb05b4cd23c74043784747c6add3094bec02d 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2015-07-10  Csaba OsztrogonÃ¡c  <ossy@webkit.org>
>+
>+        Remove redundant COMPILER(CLANG) guards
>+        https://bugs.webkit.org/show_bug.cgi?id=146833
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * interpreter/StackVisitor.cpp:
>+        (JSC::logF):
>+        * runtime/MathCommon.h:
>+        (JSC::clz32):
>+
> 2015-07-09  Mark Lam  <mark.lam@apple.com>
> 
>         SymbolTable::entryFor() should do a bounds check before indexing into the localToEntry vector.
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index f4f5f3e2fd219913a5b2e66c2e5c73fa3d3a2bcf..d7b32f4257d6159f768b702f842000d42c2ea629 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,13 @@
>+2015-07-10  Csaba OsztrogonÃ¡c  <ossy@webkit.org>
>+
>+        Remove redundant COMPILER(CLANG) guards
>+        https://bugs.webkit.org/show_bug.cgi?id=146833
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/Assertions.cpp:
>+        * wtf/Assertions.h:
>+
> 2015-07-09  Tim Horton  <timothy_horton@apple.com>
> 
>         Use CoreAnimation fences instead of synchronous IPC to synchronize resize
>diff --git a/Source/JavaScriptCore/interpreter/StackVisitor.cpp b/Source/JavaScriptCore/interpreter/StackVisitor.cpp
>index 6496fa4d4570e7f13d7f3a3d0528c80d35834172..8586b6a2421e940e208a6d2609cbd905a1416bef 100644
>--- a/Source/JavaScriptCore/interpreter/StackVisitor.cpp
>+++ b/Source/JavaScriptCore/interpreter/StackVisitor.cpp
>@@ -331,7 +331,7 @@ void logF(unsigned indent, const char* format, const Types&... values)
> {
>     printIndents(indent);
> 
>-#if COMPILER(CLANG) || COMPILER(GCC)
>+#if COMPILER(GCC)
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wformat-nonliteral"
> #pragma GCC diagnostic ignored "-Wmissing-format-attribute"
>@@ -339,7 +339,7 @@ void logF(unsigned indent, const char* format, const Types&... values)
> 
>     dataLogF(format, values...);
> 
>-#if COMPILER(CLANG) || COMPILER(GCC)
>+#if COMPILER(GCC)
> #pragma GCC diagnostic pop
> #endif
> }
>diff --git a/Source/JavaScriptCore/runtime/MathCommon.h b/Source/JavaScriptCore/runtime/MathCommon.h
>index 840d8635ff5a004e5a59ffce4077bba1a602d84c..bfd728295b0ec86cc486ee737bb8c10908baa551 100644
>--- a/Source/JavaScriptCore/runtime/MathCommon.h
>+++ b/Source/JavaScriptCore/runtime/MathCommon.h
>@@ -37,7 +37,7 @@ double JIT_OPERATION operationMathPow(double x, double y) WTF_INTERNAL;
> 
> inline int clz32(uint32_t number)
> {
>-#if COMPILER(GCC) || COMPILER(CLANG)
>+#if COMPILER(GCC)
>     int zeroCount = 32;
>     if (number)
>         zeroCount = __builtin_clz(number);
>diff --git a/Source/WTF/wtf/Assertions.cpp b/Source/WTF/wtf/Assertions.cpp
>index f736f851ac4d7706b879808d393ceb2de9d8cf19..a7606604844936c491ac7be8d8a87c90335e4e4a 100644
>--- a/Source/WTF/wtf/Assertions.cpp
>+++ b/Source/WTF/wtf/Assertions.cpp
>@@ -140,7 +140,7 @@ static void vprintf_stderr_common(const char* format, va_list args)
>     vfprintf(stderr, format, args);
> }
> 
>-#if COMPILER(CLANG) || COMPILER(GCC)
>+#if COMPILER(GCC)
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wformat-nonliteral"
> #endif
>@@ -173,7 +173,7 @@ static void vprintf_stderr_with_trailing_newline(const char* format, va_list arg
>     vprintf_stderr_common(formatWithNewline.get(), args);
> }
> 
>-#if COMPILER(CLANG) || COMPILER(GCC)
>+#if COMPILER(GCC)
> #pragma GCC diagnostic pop
> #endif
> 
>@@ -320,7 +320,7 @@ void WTFCrash()
>     WTFReportBacktrace();
>     *(int *)(uintptr_t)0xbbadbeef = 0;
>     // More reliable, but doesn't say BBADBEEF.
>-#if COMPILER(CLANG) || COMPILER(GCC)
>+#if COMPILER(GCC)
>     __builtin_trap();
> #else
>     ((void(*)())0)();
>@@ -334,7 +334,7 @@ void WTFCrashWithSecurityImplication()
>     WTFReportBacktrace();
>     *(int *)(uintptr_t)0xfbadbeef = 0;
>     // More reliable, but doesn't say fbadbeef.
>-#if COMPILER(CLANG) || COMPILER(GCC)
>+#if COMPILER(GCC)
>     __builtin_trap();
> #else
>     ((void(*)())0)();
>diff --git a/Source/WTF/wtf/Assertions.h b/Source/WTF/wtf/Assertions.h
>index d99a0d5d1f4faea53f2d456b64312a0657975009..873796f636f52857e371419925f8cae77fa30c4c 100644
>--- a/Source/WTF/wtf/Assertions.h
>+++ b/Source/WTF/wtf/Assertions.h
>@@ -114,7 +114,7 @@ extern "C" {
> 
>    Signals are ignored by the crash reporter on OS X so we must do better.
> */
>-#if COMPILER(CLANG) || COMPILER(GCC) || COMPILER(MSVC)
>+#if COMPILER(GCC) || COMPILER(MSVC)
> #define NO_RETURN_DUE_TO_CRASH NO_RETURN
> #else
> #define NO_RETURN_DUE_TO_CRASH

Actions: View | Formatted Diff | Diff

Attachments on bug 146833: 256576 | 256577 | 257744 | 257843