Attachment 252088 Details for Bug 144447 – style

[patch] style

style.patch (text/plain), 3.81 KB, created by Doug Russell on 2015-04-30 14:31:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Doug Russell

Created: 2015-04-30 14:31:22 PDT

Size: 3.81 KB

patch

obsolete

>diff --git a/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp
>index 43d5892..d27c5eb 100644
>--- a/Source/WebCore/accessibility/AXObjectCache.cpp
>+++ b/Source/WebCore/accessibility/AXObjectCache.cpp
>@@ -911,6 +911,9 @@ void AXObjectCache::showIntent(const AXTextStateChangeIntent &intent)
>         case AXTextEditTypePaste:
>             dataLog("Paste");
>             break;
>+        case AXTextEditTypeStyle:
>+            dataLog("Style");
>+            break;
>         }
>         break;
>     case AXTextStateChangeTypeSelectionMove:
>diff --git a/Source/WebCore/accessibility/AXTextStateChangeIntent.h b/Source/WebCore/accessibility/AXTextStateChangeIntent.h
>index 95c264f..11eada1 100644
>--- a/Source/WebCore/accessibility/AXTextStateChangeIntent.h
>+++ b/Source/WebCore/accessibility/AXTextStateChangeIntent.h
>@@ -42,7 +42,8 @@ enum AXTextEditType {
>     AXTextEditTypeTyping, // Insert via typing
>     AXTextEditTypeDictation, // Insert via dictation
>     AXTextEditTypeCut, // Delete via Cut
>-    AXTextEditTypePaste // Insert via Paste
>+    AXTextEditTypePaste, // Insert via Paste
>+    AXTextEditTypeStyle
> };
> 
> enum AXTextSelectionDirection {
>diff --git a/Source/WebCore/editing/EditCommand.cpp b/Source/WebCore/editing/EditCommand.cpp
>index 6478ae6..7f54f30 100644
>--- a/Source/WebCore/editing/EditCommand.cpp
>+++ b/Source/WebCore/editing/EditCommand.cpp
>@@ -129,8 +129,43 @@ AXTextEditType EditCommand::applyEditType() const
>         return AXTextEditTypePaste;
>     case EditActionTyping:
>         return AXTextEditTypeTyping;
>-    // Include default case for unhandled EditAction cases.
>-    default:
>+    case EditActionSetColor:
>+    case EditActionSetBackgroundColor:
>+    case EditActionTurnOffKerning:
>+    case EditActionTightenKerning:
>+    case EditActionLoosenKerning:
>+    case EditActionUseStandardKerning:
>+    case EditActionTurnOffLigatures:
>+    case EditActionUseStandardLigatures:
>+    case EditActionUseAllLigatures:
>+    case EditActionRaiseBaseline:
>+    case EditActionLowerBaseline:
>+    case EditActionSetTraditionalCharacterShape:
>+    case EditActionSetFont:
>+    case EditActionChangeAttributes:
>+    case EditActionAlignLeft:
>+    case EditActionAlignRight:
>+    case EditActionCenter:
>+    case EditActionJustify:
>+    case EditActionSetWritingDirection:
>+    case EditActionSubscript:
>+    case EditActionSuperscript:
>+    case EditActionUnderline:
>+    case EditActionOutline:
>+    case EditActionUnscript:
>+    case EditActionBold:
>+    case EditActionItalics:
>+    case EditActionPasteFont:
>+    case EditActionPasteRuler:
>+    case EditActionFormatBlock:
>+        return AXTextEditTypeStyle;
>+    case EditActionCreateLink:
>+    case EditActionUnlink:
>+    case EditActionInsertList:
>+    case EditActionDrag:
>+    case EditActionIndent:
>+    case EditActionOutdent:
>+    case EditActionUnspecified:
>         break;
>     }
>     return AXTextEditTypeUnknown;
>@@ -149,6 +184,8 @@ AXTextEditType EditCommand::unapplyEditType() const
>     case AXTextEditTypeDictation:
>     case AXTextEditTypePaste:
>         return AXTextEditTypeDelete;
>+    case AXTextEditTypeStyle:
>+        return AXTextEditTypeStyle;
>     }
>     return AXTextEditTypeUnknown;
> }
>diff --git a/Source/WebCore/editing/ReplaceInsertIntoTextNodeCommand.cpp b/Source/WebCore/editing/ReplaceInsertIntoTextNodeCommand.cpp
>index 8348c11..66e5ea3 100644
>--- a/Source/WebCore/editing/ReplaceInsertIntoTextNodeCommand.cpp
>+++ b/Source/WebCore/editing/ReplaceInsertIntoTextNodeCommand.cpp
>@@ -60,6 +60,9 @@ void ReplaceInsertIntoTextNodeCommand::notifyAccessibilityForTextChange(Node* no
>     case AXTextEditTypeTyping:
>         cache->postTextReplacementNotification(node, AXTextEditTypeDelete, m_deletedText, type, text, position);
>         break;
>+    case AXTextEditTypeStyle:
>+        // FIXME not sure what this should do
>+        break;
>     }
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 144447: 252088 | 252098 | 252121 | 252158