Attachment 246507 Details for Bug 33342 – fourth attempt

[patch] fourth attempt

EventListenerGC.txt (text/plain), 2.15 KB, created by Alexey Proskuryakov on 2015-02-12 22:14:29 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2015-02-12 22:14:29 PST

Size: 2.15 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 180029)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2015-02-12  Alexey Proskuryakov  <ap@apple.com>
>+
>+        http/tests/xmlhttprequest/event-listener-gc.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=33342
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Instead of using a zero delay timer, which can be legitimately delayed for dozens
>+        of milliseconds, perform the collection in a second load event handler. GC code
>+        has changed so much that I cannot confirm that the test still verifies the fix,
>+        however we collect after returning for the function and unwinding the stack, so it should.
>+
>+        Also, clear the JS variable for a good measure.
>+
>+        * http/tests/xmlhttprequest/event-listener-gc.html:
>+
> 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
> 
>         [Win] More media rebaselining.
>Index: LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html
>===================================================================
>--- LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html	(revision 179864)
>+++ LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html	(working copy)
>@@ -30,21 +30,19 @@ function test() 
>         testRunner.waitUntilDone();
>     }
> 
>-    // Force layout now, as otherwise it will occur before our garbage collection timer,
>-    // possibly delaying it until after XMLHttpRequest finishes.
>-    document.body.offsetTop;
>-
>     var request = new XMLHttpRequest();
>     request.onreadystatechange = processStateChange;
>     request.open("GET", "resources/print-headers.cgi", true);
>     request.send(null);
>-
>-    setTimeout('collect();', 0);
>+    request = null;
> }
>+
>+window.addEventListener("load", test);
>+window.addEventListener("load", collect);
> </script>
> </head>
> 
>-<body onload="test();">
>+<body>
> <p>This test checks whether event handlers for outstanding XMLHttpRequests survive garbage collection.</p>
> <p>See https://bugs.webkit.org/show_bug.cgi?id=9113 REGRESSION (14581): 
> XMLHttpRequest never calls onreadystatechange with a readystate == 4</p>

Actions: View | Formatted Diff | Diff

Attachments on bug 33342: 245960 | 246091 | 246216 | 246507