Attachment 23432 Details for Bug 20180 – Enable an existing optimization that wasn't being triggered

[patch] Enable an existing optimization that wasn't being triggered

collectrulesonlyspeedup.txt (text/plain), 1.54 KB, created by David Smith on 2008-09-15 01:06:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Smith

Created: 2008-09-15 01:06:53 PDT

Size: 1.54 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 36429)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2008-09-15  David Smith  <catfish.man@gmail.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=20180
>+        
>+        >2x speed up for :nth-child in querySelectorAll by allowing it to cache each element's index in its parent element. No change on non-querySelector/querySelectorAll.
>+
>+        * dom/SelectorNodeList.cpp:
>+        (WebCore::createSelectorNodeList): Pass false for collectRulesOnly
>+
> 2008-09-14  Dave Hyatt  <hyatt@apple.com>
> 
>         Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin.  PlatformScrollbarSafari
>Index: WebCore/dom/SelectorNodeList.cpp
>===================================================================
>--- WebCore/dom/SelectorNodeList.cpp	(revision 36403)
>+++ WebCore/dom/SelectorNodeList.cpp	(working copy)
>@@ -54,7 +54,7 @@ PassRefPtr<StaticNodeList> createSelecto
>         if (element && (rootNode->isDocumentNode() || element->isDescendantOf(rootNode)))
>             nodes.append(element);
>     } else {
>-        CSSStyleSelector::SelectorChecker selectorChecker(document, strictParsing);
>+        CSSStyleSelector::SelectorChecker selectorChecker(document, strictParsing, false);
>         for (Node* n = rootNode->firstChild(); n; n = n->traverseNextNode(rootNode)) {
>             if (n->isElementNode()) {
>                 Element* element = static_cast<Element*>(n);

Actions: View | Formatted Diff | Diff

Attachments on bug 20180: 23244 | 23333 | 23336 | 23337 | 23341 | 23417 | 23432