Attachment 22748 Details for Bug 19301 – Proposed patch

[patch] Proposed patch

0001-Make-attaching-and-detaching-the-Web-Inspect.patch (text/plain), 2.06 KB, created by Timothy Hatcher on 2008-08-12 07:41:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2008-08-12 07:41:55 PDT

Size: 2.06 KB

patch

obsolete

>From a87ea099bc0e14fa7a27a330c2b1cdec1683ef60 Mon Sep 17 00:00:00 2001
>From: Timothy Hatcher <timothy@apple.com>
>Date: Tue, 12 Aug 2008 07:41:12 -0700
>Subject: [PATCH]         Make attaching and detaching the Web Inspector instantaneous.
>         This also preserves the current view, other state, and keeps
>         the script debugger attached.
>
>        https://bugs.webkit.org/show_bug.cgi?id=19301
>
>        Reviewed by NOBODY (OOPS!).
>
>        * WebCoreSupport/WebInspectorClient.mm:
>        (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
>        when not moving windows.
>---
> WebKit/mac/ChangeLog                            |   14 ++++++++++++++
> WebKit/mac/WebCoreSupport/WebInspectorClient.mm |    3 ++-
> 2 files changed, 16 insertions(+), 1 deletions(-)
>
>diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
>index 494c926..660a628 100644
>--- a/WebKit/mac/ChangeLog
>+++ b/WebKit/mac/ChangeLog
>@@ -1,3 +1,17 @@
>+2008-08-12  Timothy Hatcher  <timothy@apple.com>
>+
>+        Make attaching and detaching the Web Inspector instantaneous.
>+        This also preserves the current view, other state, and keeps
>+        the script debugger attached.
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=19301
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebCoreSupport/WebInspectorClient.mm:
>+        (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
>+        when not moving windows.
>+
> 2008-08-08  Dan Bernstein  <mitz@apple.com>
> 
>         Reviewed by John Sullivan.
>diff --git a/WebKit/mac/WebCoreSupport/WebInspectorClient.mm b/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
>index 3ef5367..edd2c3e 100644
>--- a/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
>+++ b/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
>@@ -266,7 +266,8 @@ void WebInspectorClient::updateWindowTitle() const
> 
>     _visible = NO;
> 
>-    [_inspectedWebView page]->inspectorController()->setWindowVisible(false);
>+    if (!_movingWindows)
>+        [_inspectedWebView page]->inspectorController()->setWindowVisible(false);
> 
>     [self hideHighlight];
> 
>-- 
>1.5.4.4
>

Flags:

aroben: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 19301: 22748