Attachment 227428 Details for Bug 130585 – Patch

[patch] Patch

bug-130585-20140321155919.patch (text/plain), 1.60 KB, created by Andres Gomez Garcia on 2014-03-21 06:59:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andres Gomez Garcia

Created: 2014-03-21 06:59:41 PDT

Size: 1.60 KB

patch

obsolete

>Subversion Revision: 166045
>diff --git a/Source/cmake/OptionsGTK.cmake b/Source/cmake/OptionsGTK.cmake
>index fda1d6094dd62bfbfc84d71871a10cbd491dee45..ac491d1023e55d17c8b48125e765385823e82f4b 100644
>--- a/Source/cmake/OptionsGTK.cmake
>+++ b/Source/cmake/OptionsGTK.cmake
>@@ -304,6 +304,14 @@ if (UNIX AND NOT APPLE)
>     endif ()
> endif ()
> 
>+# We need GCC >= 4.8.0 to avoid ambiguous errors on overloaded functions using std::function
>+# See https://bugs.webkit.org/show_bug.cgi?id=130585
>+if (CMAKE_COMPILER_IS_GNUCXX)
>+    if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.8.0")
>+        message(FATAL_ERROR "You need at least GCC 4.8.0 and current version is ${CMAKE_CXX_COMPILER_VERSION}")
>+    endif ()
>+endif ()
>+
> # Add a typelib file to the list of all typelib dependencies. This makes it easy to
> # expose a 'gir' target with all gobject-introspection files.
> macro(ADD_TYPELIB typelib)
>diff --git a/ChangeLog b/ChangeLog
>index a17722bdb30750cfe8d07b132b91b3954a14320a..d87a05af42c66206f906827579b2150fe46b101f 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,17 @@
>+2014-03-21  Andres Gomez  <agomez@igalia.com>
>+
>+        [GTK] Build fails with GCC < 4.8.x
>+        https://bugs.webkit.org/show_bug.cgi?id=130585
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The behavior in lower versions of GCC seem to be related to
>+        http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2132.
>+
>+        Bumped minimum needed GCC version to 4.8.0.
>+
>+        * Source/cmake/OptionsGTK.cmake:
>+
> 2014-03-20  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
> 
>         [EFL][GTK] Get CMake to find Freetype2 properly

Flags:

mrobinson: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 130585: 227423 | 227425 | 227428 | 227429 | 228738 | 228739