Attachment 21958 Details for Bug 19762 – First attempt

[patch] First attempt

19762.diff (text/plain), 1.34 KB, created by Rob Buis on 2008-06-26 12:59:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2008-06-26 12:59:55 PDT

Size: 1.34 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 34811)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2008-06-26  Rob Buis  <buis@kde.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=19762
>+        Crash in svg/webarchive/svg-cursor-subresources.svg
>+
>+        Remove elements that have an id from the id cache
>+        in the document so getElementById will not return
>+        elements that are already deleted.
>+
>+        WARNING: NO TEST CASES ADDED OR CHANGED
>+
>+        * dom/Element.cpp:
>+        (WebCore::Element::~Element):
>+
> 2008-06-26  Anders Carlsson  <andersca@apple.com>
> 
>         Reviewed by Brady.
>Index: WebCore/dom/Element.cpp
>===================================================================
>--- WebCore/dom/Element.cpp	(revision 34808)
>+++ WebCore/dom/Element.cpp	(working copy)
>@@ -105,6 +105,14 @@ Element::Element(const QualifiedName& qN
> 
> Element::~Element()
> {
>+    if (hasID()) {
>+        if (NamedAttrMap* attrs = namedAttrMap.get()) {
>+            Attribute* idItem = attrs->getAttributeItem(idAttr);
>+            if (idItem && !idItem->isNull())
>+                document()->removeElementById(idItem->value(), this);
>+        }
>+    }
>+
>     if (namedAttrMap)
>         namedAttrMap->detachFromElement();
>

Flags:

ap: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 19762: 21958 | 22100