Attachment 215476 Details for Bug 29751 – proposed fix

[patch] proposed fix

DeletePreferences.txt (text/plain), 1.92 KB, created by Alexey Proskuryakov on 2013-10-30 00:01:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2013-10-30 00:01:48 PDT

Size: 1.92 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 158256)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2013-10-29  Alexey Proskuryakov  <ap@apple.com>
>+
>+        DumpRenderTree should reset its preferences file on launch
>+        https://bugs.webkit.org/show_bug.cgi?id=29751
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
>+        * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
>+        Do it. TestWebKitAPI already did.
>+
> 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
> 
>         Result of focus-option-control-on-page.html depends on system preferences
>Index: Tools/DumpRenderTree/mac/DumpRenderTree.mm
>===================================================================
>--- Tools/DumpRenderTree/mac/DumpRenderTree.mm	(revision 158242)
>+++ Tools/DumpRenderTree/mac/DumpRenderTree.mm	(working copy)
>@@ -676,6 +676,8 @@ static void resetWebPreferencesToConsist
> // Called once on DumpRenderTree startup.
> static void setDefaultsToConsistentValuesForTesting()
> {
>+    [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"DumpRenderTree"];
>+
>     // FIXME: We'd like to start with a clean state for every test, but this function can't be used more than once yet.
>     [WebPreferences _switchNetworkLoaderToNewTestingSession];
> 
>Index: Tools/WebKitTestRunner/mac/main.mm
>===================================================================
>--- Tools/WebKitTestRunner/mac/main.mm	(revision 158242)
>+++ Tools/WebKitTestRunner/mac/main.mm	(working copy)
>@@ -29,6 +29,8 @@
> 
> static void setDefaultsToConsistentValuesForTesting()
> {
>+    [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"WebKitTestRunner"];
>+
>     NSDictionary *dict = @{
>         @"AppleMagnifiedMode": @YES,
>         @"WebKitKerningAndLigaturesEnabledByDefault": @NO,

Flags:

rniwa: review+
buildbot: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 29751: 215476 | 215485 | 215551 | 215571 | 215892