Attachment 214966 Details for Bug 123209 – Patch

[patch] Patch

123209.patch (text/plain), 2.01 KB, created by Michael Saboff on 2013-10-23 08:49:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2013-10-23 08:49:21 PDT

Size: 2.01 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 157857)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2013-10-23  Michael Saboff  <msaboff@apple.com>
>+
>+        LLInt arity check exception processing should start unwinding from caller
>+        https://bugs.webkit.org/show_bug.cgi?id=123209
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use the caller frame returned from slow_path_call_arityCheck to process exceptions.
>+
>+        * llint/LowLevelInterpreter32_64.asm:
>+        * llint/LowLevelInterpreter64.asm:
>+
> 2013-10-22  Andreas Kling  <akling@apple.com>
> 
>         Minor VM* -> VM& cleanups in HashTable and Keywords.
>Index: Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>===================================================================
>--- Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm	(revision 157857)
>+++ Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm	(working copy)
>@@ -307,6 +307,7 @@ macro functionArityCheck(doneLabel, slow
>     biaeq t0, CodeBlock::m_numParameters[t1], doneLabel
>     cCall2(slow_path, cfr, PC)   # This slow_path has a simple protocol: t0 = 0 => no error, t0 != 0 => error
>     btiz t0, .isArityFixupNeeded
>+    move t1, cfr   # t1 contains caller frame
>     jmp _llint_throw_from_slow_path_trampoline
> 
> .isArityFixupNeeded:
>Index: Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>===================================================================
>--- Source/JavaScriptCore/llint/LowLevelInterpreter64.asm	(revision 157857)
>+++ Source/JavaScriptCore/llint/LowLevelInterpreter64.asm	(working copy)
>@@ -203,6 +203,7 @@ macro functionArityCheck(doneLabel, slow
>     prepareStateForCCall()
>     cCall2(slow_path, cfr, PC)   # This slow_path has a simple protocol: t0 = 0 => no error, t0 != 0 => error
>     btiz t0, .isArityFixupNeeded
>+    move t1, cfr   # t1 contains caller frame
>     jmp _llint_throw_from_slow_path_trampoline
> 
> .isArityFixupNeeded:

Flags:

oliver: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 123209: 214966