Attachment 201774 Details for Bug 116129 – Patch

[patch] Patch

bug-116129-20130515091417.patch (text/plain), 2.22 KB, created by Jaehun Lim on 2013-05-14 17:15:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jaehun Lim

Created: 2013-05-14 17:15:22 PDT

Size: 2.22 KB

patch

obsolete

>Subversion Revision: 150091
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e6c6841a5ab1cb809123e43ad347844dd5e240e0..785539867cf77e75bb264e3d240c9a6418f6fa87 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
>+
>+        Fix build after r149944.
>+        https://bugs.webkit.org/show_bug.cgi?id=116129
>+
>+        Unreviewed build fix after r149944.
>+
>+        * DumpRenderTree/TestRunner.cpp:
>+        (getSecureEventInputIsEnabledCallback):
>+        * WebKitTestRunner/TestInvocation.cpp:
>+        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
>+
> 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
> 
>         [Mac] Add tests for secure event input
>diff --git a/Tools/DumpRenderTree/TestRunner.cpp b/Tools/DumpRenderTree/TestRunner.cpp
>index f6172c89af2c67dc37496758dbb61a3f33527583..b546343bd873254a470389e39359b922c5bb19a3 100644
>--- a/Tools/DumpRenderTree/TestRunner.cpp
>+++ b/Tools/DumpRenderTree/TestRunner.cpp
>@@ -1840,7 +1840,11 @@ static JSValueRef getPlatformNameCallback(JSContextRef context, JSObjectRef this
> 
> static JSValueRef getSecureEventInputIsEnabledCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
> {
>+#if PLATFORM(MAC)
>     return JSValueMakeBoolean(context, IsSecureEventInputEnabled());
>+#else
>+    return JSValueMakeBoolean(context, false);
>+#endif
> }
> 
> static JSValueRef getTitleTextDirectionCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
>diff --git a/Tools/WebKitTestRunner/TestInvocation.cpp b/Tools/WebKitTestRunner/TestInvocation.cpp
>index 715dca495817d6cc297043afdec767abe135a8f9..393040832461fbeca2465f062d56faf90103c514 100644
>--- a/Tools/WebKitTestRunner/TestInvocation.cpp
>+++ b/Tools/WebKitTestRunner/TestInvocation.cpp
>@@ -668,7 +668,7 @@ WKRetainPtr<WKTypeRef> TestInvocation::didReceiveSynchronousMessageFromInjectedB
> #if PLATFORM(MAC)
>         WKRetainPtr<WKBooleanRef> result(AdoptWK, WKBooleanCreate(IsSecureEventInputEnabled()));
> #else
>-        WKRetainPtr<WKBooleanRef> result(AdoptWK, WKBooleanCreate(false);
>+        WKRetainPtr<WKBooleanRef> result(AdoptWK, WKBooleanCreate(false));
> #endif
>         return result;
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 116129: 201774 | 201775 | 201776