Attachment 201621 Details for Bug 116054 – Patch

[patch] Patch

bug-116054-20130513123423.patch (text/plain), 10.80 KB, created by Anders Carlsson on 2013-05-13 12:35:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Anders Carlsson

Created: 2013-05-13 12:35:25 PDT

Size: 10.80 KB

patch

obsolete

>Subversion Revision: 150030
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6cbacba109c54d769039084e66b7b16e344877eb..bf12b775d6ee70a7fcf6bb6e7b1b0e6cfb2b5824 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * loader/EmptyClients.h:
>+        * page/ChromeClient.h:
>+        (ChromeClient):
>+
> 2013-05-13  Bem Jones-Bey  <bjonesbe@adobe.com>
> 
>         Floats should not overhang from flex items
>diff --git a/Source/WebKit/blackberry/ChangeLog b/Source/WebKit/blackberry/ChangeLog
>index e655c3c14277e088832bd2938a5e67d5b17a4737..6e27189ccd1f2941d90c5adb7a13fc8dbd6f69e1 100644
>--- a/Source/WebKit/blackberry/ChangeLog
>+++ b/Source/WebKit/blackberry/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/ChromeClientBlackBerry.h:
>+        (ChromeClientBlackBerry):
>+
> 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
> 
>         Remove USE(OS_RANDOMNESS)
>diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
>index ac84f44c0b1af7728f50ead1d96650809358deb4..9681f4bee4dd22831f1aac3baff245ef4c4af61a 100644
>--- a/Source/WebKit/efl/ChangeLog
>+++ b/Source/WebKit/efl/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/ChromeClientEfl.h:
>+        (ChromeClientEfl):
>+
> 2013-05-12  Anders Carlsson  <andersca@apple.com>
> 
>         Stop including UnusedParam.h
>diff --git a/Source/WebKit/gtk/ChangeLog b/Source/WebKit/gtk/ChangeLog
>index 3f022a4f16d7cb40090aab02361f13190dd49836..d7ea412bd4ac1e54e950cabee0ce926fd8479acc 100644
>--- a/Source/WebKit/gtk/ChangeLog
>+++ b/Source/WebKit/gtk/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/ChromeClientGtk.h:
>+        (ChromeClient):
>+
> 2013-05-12  Anders Carlsson  <andersca@apple.com>
> 
>         Stop including UnusedParam.h
>diff --git a/Source/WebKit/mac/ChangeLog b/Source/WebKit/mac/ChangeLog
>index 36753dc604ed2570d844de6b8ed23709b257382f..ac7c36c24891194285478f766dfeafc8bfc88324 100644
>--- a/Source/WebKit/mac/ChangeLog
>+++ b/Source/WebKit/mac/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/WebChromeClient.h:
>+        (WebChromeClient):
>+
> 2013-05-13  Zalan Bujtas  <zalan@apple.com>
> 
>         WebProcess consuming very high CPU on linkedin.com
>diff --git a/Source/WebKit/qt/ChangeLog b/Source/WebKit/qt/ChangeLog
>index 3fb558be5f9d999c5a2151a4a6289f52d7924e1e..1dec5386915038172c28363ecfc6e6b8acc1db0e 100644
>--- a/Source/WebKit/qt/ChangeLog
>+++ b/Source/WebKit/qt/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/ChromeClientQt.h:
>+        (ChromeClientQt):
>+
> 2013-05-13  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
> 
>         [Qt] Fix a crash on startup in FrameLoaderClientQt::callPolicyFunction with MSVC
>diff --git a/Source/WebKit/win/ChangeLog b/Source/WebKit/win/ChangeLog
>index ab5cae373789158f29866a926cf14448bd5b8793..01565767a9e2a594b13ab6f5454aa2420c20920d 100644
>--- a/Source/WebKit/win/ChangeLog
>+++ b/Source/WebKit/win/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/WebChromeClient.h:
>+        (WebChromeClient):
>+
> 2013-05-13  Roger Fong  <roger_fong@apple.com>
> 
>         Unreviewed. AppleWin VS2005 build fix.
>diff --git a/Source/WebKit/wince/ChangeLog b/Source/WebKit/wince/ChangeLog
>index ecb9a2c00d5dfb9a3e9a0b1d5204ecb7a98f4e54..c4bff968501bec0fc6bb123a05b559cedd45185a 100644
>--- a/Source/WebKit/wince/ChangeLog
>+++ b/Source/WebKit/wince/ChangeLog
>@@ -1,3 +1,15 @@
>+2013-05-13  Anders Carlsson  <andersca@apple.com>
>+
>+        Remove ChromeClient::webView()
>+        https://bugs.webkit.org/show_bug.cgi?id=116054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
>+
>+        * WebCoreSupport/ChromeClientWinCE.h:
>+        (ChromeClientWinCE):
>+
> 2013-04-29  Patrick Gansterer  <paroga@webkit.org>
> 
>         Unreviewed build fix.
>diff --git a/Source/WebCore/loader/EmptyClients.h b/Source/WebCore/loader/EmptyClients.h
>index d8fbb6b571c013594c62ce656afaa335295e556f..d0fc5fc7524086c9f0a7c464405bbd89673ce50b 100644
>--- a/Source/WebCore/loader/EmptyClients.h
>+++ b/Source/WebCore/loader/EmptyClients.h
>@@ -66,7 +66,6 @@ public:
>     virtual ~EmptyChromeClient() { }
>     virtual void chromeDestroyed() { }
> 
>-    virtual void* webView() const { return 0; }
>     virtual void setWindowRect(const FloatRect&) { }
>     virtual FloatRect windowRect() { return FloatRect(); }
> 
>diff --git a/Source/WebCore/page/ChromeClient.h b/Source/WebCore/page/ChromeClient.h
>index e52156f7e232ea86552b0f9a7b430d96264782a8..3c7e2be7159b813fdd6c3d1b48aac93205defc75 100644
>--- a/Source/WebCore/page/ChromeClient.h
>+++ b/Source/WebCore/page/ChromeClient.h
>@@ -147,8 +147,6 @@ public:
>     virtual bool shouldInterruptJavaScript() = 0;
>     virtual KeyboardUIMode keyboardUIMode() = 0;
> 
>-    virtual void* webView() const = 0;
>-
>     virtual IntRect windowResizerRect() const = 0;
> 
>     // Methods used by HostWindow.
>diff --git a/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h b/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h
>index 44658a87e625bc61cfc1ead6faccba4c91cef042..e8933f1bd2e2f7dcb4a1753b6d7fdcdfd22b5b09 100644
>--- a/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h
>+++ b/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h
>@@ -36,7 +36,6 @@ public:
>     ChromeClientBlackBerry(BlackBerry::WebKit::WebPagePrivate*);
> 
>     virtual void chromeDestroyed();
>-    virtual void* webView() const { return 0; };
>     virtual void setWindowRect(const FloatRect&);
>     virtual FloatRect windowRect();
>     virtual FloatRect pageRect();
>diff --git a/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h b/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h
>index c5751891da2b9e579ef9d9829aac17178eb99573..257a9874d676cb83014cb490edff8cd69cda6017 100644
>--- a/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h
>+++ b/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h
>@@ -45,7 +45,6 @@ public:
> 
>     virtual void chromeDestroyed();
> 
>-    virtual void* webView() const { return 0; }
>     virtual void setWindowRect(const FloatRect&);
>     virtual FloatRect windowRect();
> 
>diff --git a/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h b/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h
>index a27f46ec06f28dc4c2aa313d662f42a7af02fd4e..97fc9776c36d2f618cc6627badf1d751996d4cf6 100644
>--- a/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h
>+++ b/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h
>@@ -43,7 +43,6 @@ namespace WebKit {
>     class ChromeClient : public WebCore::ChromeClient {
>     public:
>         ChromeClient(WebKitWebView*);
>-        virtual void* webView() const { return m_webView; }
>         GtkAdjustmentWatcher* adjustmentWatcher() { return &m_adjustmentWatcher; }
> 
>         virtual void chromeDestroyed();
>diff --git a/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h b/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
>index ab90d8f3f4cf1be828d4317cccfe7f854d85703d..d00096fd252ee914865ebbdaa7072d52a720aaca 100644
>--- a/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
>+++ b/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
>@@ -36,7 +36,6 @@
> class WebChromeClient : public WebCore::ChromeClient {
> public:
>     WebChromeClient(WebView*);
>-    virtual void* webView() const { return static_cast<void*>(m_webView); }
>     
>     virtual void chromeDestroyed() OVERRIDE;
>     
>diff --git a/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h b/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h
>index 8f97dc7aa86c004e3f32280957939963c5247bd2..967edd278183c006d1d095f0f2b540fbe60af8c8 100644
>--- a/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h
>+++ b/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h
>@@ -66,7 +66,6 @@ public:
>     virtual ~ChromeClientQt();
>     virtual void chromeDestroyed();
> 
>-    virtual void* webView() const { return 0; }
>     virtual void setWindowRect(const FloatRect&);
>     virtual FloatRect windowRect();
> 
>diff --git a/Source/WebKit/win/WebCoreSupport/WebChromeClient.h b/Source/WebKit/win/WebCoreSupport/WebChromeClient.h
>index ca29daf722078de6620354655ba7e626e2368299..3166032ca9314c3626ef6f629d791b7739af78af 100644
>--- a/Source/WebKit/win/WebCoreSupport/WebChromeClient.h
>+++ b/Source/WebKit/win/WebCoreSupport/WebChromeClient.h
>@@ -43,8 +43,6 @@ public:
> 
>     virtual void chromeDestroyed();
> 
>-    virtual void* webView() const { return m_webView; }
>-
>     virtual void setWindowRect(const WebCore::FloatRect&);
>     virtual WebCore::FloatRect windowRect();
>     
>diff --git a/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h b/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h
>index 6aa56d97e050a26b4535267152e5439aa081e944..0fd76122d8400c96beda72015d37d2d177a4418a 100644
>--- a/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h
>+++ b/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h
>@@ -37,7 +37,6 @@ public:
> 
>     virtual void chromeDestroyed();
> 
>-    virtual void* webView() const { return 0; }
>     virtual void setWindowRect(const WebCore::FloatRect&);
>     virtual WebCore::FloatRect windowRect();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 116054: 201621 | 202239 | 202240