Attachment 198703 Details for Bug 114670 – remove warning (unused parameter ) in /Source/WebKit/blackberry/Api

[patch] remove warning (unused parameter ) in /Source/WebKit/blackberry/Api

0001-remove-build-warning-unused-parameter.patch (text/plain), 9.70 KB, created by xuefeiren on 2013-04-18 02:44:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: xuefeiren

Created: 2013-04-18 02:44:12 PDT

Size: 9.70 KB

patch

obsolete

>From 018ecf3683139c4e6b7d4413b3eb93e4113a477b Mon Sep 17 00:00:00 2001
>From: Xuefei Ren <xren@blackberry.com>
>Date: Thu, 18 Apr 2013 17:42:51 +0800
>Subject: [PATCH] remove build warning(unused parameter)
> https://bugs.webkit.org/show_bug.cgi?id=114670
>
>Reviewed by NOBODY (OOPS!).
>
>remove build warning in Source/WebKit/blackberry/Api
>
>* Api/BackingStore.cpp:
>(BlackBerry::WebKit::BackingStorePrivate::scroll):
>(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
>(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
>(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
>(BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):
>* Api/BlackBerryGlobal.cpp:
>(BlackBerry::WebKit::clearAppCache):
>(BlackBerry::WebKit::clearDatabase):
>* Api/WebOverlay.cpp:
>(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
>(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
>(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
>(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
>* Api/WebPage.cpp:
>(BlackBerry::WebKit::WebPage::setCaretHighlightStyle):
>* Api/WebPageCompositor.cpp:
>(BlackBerry::WebKit::WebPageCompositor::cleanup):
>---
> Source/WebKit/blackberry/Api/BackingStore.cpp      |   14 +++++-----
> Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp  |    4 +--
> Source/WebKit/blackberry/Api/WebOverlay.cpp        |    8 +++---
> Source/WebKit/blackberry/Api/WebPage.cpp           |    2 +-
> Source/WebKit/blackberry/Api/WebPageCompositor.cpp |    2 +-
> Source/WebKit/blackberry/ChangeLog                 |   28 ++++++++++++++++++++
> 6 files changed, 42 insertions(+), 16 deletions(-)
>
>diff --git a/Source/WebKit/blackberry/Api/BackingStore.cpp b/Source/WebKit/blackberry/Api/BackingStore.cpp
>index 69324ac..f5a6518 100644
>--- a/Source/WebKit/blackberry/Api/BackingStore.cpp
>+++ b/Source/WebKit/blackberry/Api/BackingStore.cpp
>@@ -493,9 +493,7 @@ void BackingStorePrivate::slowScroll(const Platform::IntSize& delta, const Platf
> #endif
> }
> 
>-void BackingStorePrivate::scroll(const Platform::IntSize& delta,
>-                                 const Platform::IntRect& scrollViewRect,
>-                                 const Platform::IntRect& clipRect)
>+void BackingStorePrivate::scroll(const Platform::IntSize& delta, const Platform::IntRect&, const Platform::IntRect&)
> {
>     ASSERT(BlackBerry::Platform::webKitThreadMessageClient()->isCurrentThread());
> 
>@@ -885,9 +883,9 @@ TileIndex BackingStorePrivate::indexOfTile(const Platform::IntPoint& origin,
>     return TileIndex(offsetX, offsetY);
> }
> 
>-void BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion(const TileIndex& index, TileBuffer* tileBuffer,
>+void BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion(const TileIndex&, TileBuffer* tileBuffer,
>                                                                 const Platform::IntRectRegion& tileNotRenderedRegion,
>-                                                                BackingStoreGeometry* geometry,
>+                                                                BackingStoreGeometry*,
>                                                                 bool update)
> {
>     if (tileNotRenderedRegion.isEmpty())
>@@ -1123,7 +1121,7 @@ void BackingStorePrivate::renderAndBlitImmediately(const Platform::IntRect& rect
>     renderJob();
> }
> 
>-void BackingStorePrivate::paintDefaultBackground(const Platform::IntRect& dstRect, Platform::ViewportAccessor* viewportAccessor, bool flush)
>+void BackingStorePrivate::paintDefaultBackground(const Platform::IntRect& dstRect, Platform::ViewportAccessor* viewportAccessor, bool)
> {
>     Platform::IntRect clippedDstRect = dstRect;
> 
>@@ -1479,7 +1477,7 @@ Platform::IntRect BackingStorePrivate::blitTileRect(TileBuffer* tileBuffer,
>     const Platform::IntRect& tilePixelContentsRect,
>     const Platform::IntPoint& origin,
>     const WebCore::TransformationMatrix& matrix,
>-    BackingStoreGeometry* geometry)
>+    BackingStoreGeometry*)
> {
>     if (!m_webPage->isVisible() || !isActive() || !tileBuffer)
>         return Platform::IntRect();
>@@ -1732,7 +1730,7 @@ void BackingStorePrivate::orientationChanged()
>     updateTileMatrixIfNeeded();
> }
> 
>-void BackingStorePrivate::actualVisibleSizeChanged(const Platform::IntSize& size)
>+void BackingStorePrivate::actualVisibleSizeChanged(const Platform::IntSize&)
> {
> }
> 
>diff --git a/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp b/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp
>index e5e1bba..b355f92 100644
>--- a/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp
>+++ b/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp
>@@ -137,12 +137,12 @@ void clearMemoryCaches()
>     fontCache()->invalidate();
> }
> 
>-void clearAppCache(const BlackBerry::Platform::String& pageGroupName)
>+void clearAppCache(const BlackBerry::Platform::String&)
> {
>     cacheStorage().empty();
> }
> 
>-void clearDatabase(const BlackBerry::Platform::String& pageGroupName)
>+void clearDatabase(const BlackBerry::Platform::String&)
> {
> }
> 
>diff --git a/Source/WebKit/blackberry/Api/WebOverlay.cpp b/Source/WebKit/blackberry/Api/WebOverlay.cpp
>index 56097ee..ad4f708 100644
>--- a/Source/WebKit/blackberry/Api/WebOverlay.cpp
>+++ b/Source/WebKit/blackberry/Api/WebOverlay.cpp
>@@ -340,7 +340,7 @@ void WebOverlayPrivateWebKitThread::removeFromParent()
>     m_layer->removeFromParent();
> }
> 
>-void WebOverlayPrivateWebKitThread::setContentsToImage(const unsigned char* data, const WebCore::IntSize& imageSize, WebOverlay::ImageDataAdoptionType adoptionType)
>+void WebOverlayPrivateWebKitThread::setContentsToImage(const unsigned char*, const WebCore::IntSize&, WebOverlay::ImageDataAdoptionType)
> {
>     notImplemented();
> }
>@@ -429,7 +429,7 @@ void WebOverlayLayerCompositingThreadClient::layerCompositingThreadDestroyed(Web
>     delete this;
> }
> 
>-void WebOverlayLayerCompositingThreadClient::layerVisibilityChanged(LayerCompositingThread*, bool visible)
>+void WebOverlayLayerCompositingThreadClient::layerVisibilityChanged(LayerCompositingThread*, bool)
> {
> }
> 
>@@ -501,7 +501,7 @@ void WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded(LayerComposi
>     m_texture->updateContents(textureContents);
> }
> 
>-void WebOverlayLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program& program)
>+void WebOverlayLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program&)
> {
>     if (!m_texture || !m_texture->buffer())
>         return;
>@@ -653,7 +653,7 @@ void WebOverlayPrivateCompositingThread::removeFromParent()
>     scheduleCompositingRun();
> }
> 
>-void WebOverlayPrivateCompositingThread::setContentsToImage(const unsigned char* data, const IntSize& imageSize, WebOverlay::ImageDataAdoptionType adoptionType)
>+void WebOverlayPrivateCompositingThread::setContentsToImage(const unsigned char* data, const IntSize& imageSize, WebOverlay::ImageDataAdoptionType)
> {
>     if (!m_layerCompositingThreadClient)
>         return;
>diff --git a/Source/WebKit/blackberry/Api/WebPage.cpp b/Source/WebKit/blackberry/Api/WebPage.cpp
>index 6c71c3b..fed3ee6 100644
>--- a/Source/WebKit/blackberry/Api/WebPage.cpp
>+++ b/Source/WebKit/blackberry/Api/WebPage.cpp
>@@ -3264,7 +3264,7 @@ void WebPagePrivate::updateDelegatedOverlays(bool dispatched)
>     }
> }
> 
>-void WebPage::setCaretHighlightStyle(Platform::CaretHighlightStyle style)
>+void WebPage::setCaretHighlightStyle(Platform::CaretHighlightStyle)
> {
> }
> 
>diff --git a/Source/WebKit/blackberry/Api/WebPageCompositor.cpp b/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
>index 3f5a47b..856711e4 100644
>--- a/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
>+++ b/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
>@@ -334,7 +334,7 @@ void WebPageCompositor::render(Platform::Graphics::GLES2Context* context, const
>     d->render(targetRect, clipRect, TransformationMatrix(reinterpret_cast<const TransformationMatrix&>(transform)), documentContents, viewport);
> }
> 
>-void WebPageCompositor::cleanup(Platform::Graphics::GLES2Context* context)
>+void WebPageCompositor::cleanup(Platform::Graphics::GLES2Context*)
> {
>     d->setContext(0);
> }
>diff --git a/Source/WebKit/blackberry/ChangeLog b/Source/WebKit/blackberry/ChangeLog
>index dd7a17e..fd61e5d 100644
>--- a/Source/WebKit/blackberry/ChangeLog
>+++ b/Source/WebKit/blackberry/ChangeLog
>@@ -1,3 +1,31 @@
>+2013-04-18  Xuefei Ren  <xren@blackberry.com>
>+
>+        remove build warning(unused parameter)
>+        https://bugs.webkit.org/show_bug.cgi?id=114670
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        remove build warning in Source/WebKit/blackberry/Api
>+
>+        * Api/BackingStore.cpp:
>+        (BlackBerry::WebKit::BackingStorePrivate::scroll):
>+        (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
>+        (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
>+        (BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
>+        (BlackBerry::WebKit::BackingStorePrivate::actualVisibleSizeChanged):
>+        * Api/BlackBerryGlobal.cpp:
>+        (BlackBerry::WebKit::clearAppCache):
>+        (BlackBerry::WebKit::clearDatabase):
>+        * Api/WebOverlay.cpp:
>+        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
>+        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
>+        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
>+        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
>+        * Api/WebPage.cpp:
>+        (BlackBerry::WebKit::WebPage::setCaretHighlightStyle):
>+        * Api/WebPageCompositor.cpp:
>+        (BlackBerry::WebKit::WebPageCompositor::cleanup):
>+
> 2013-04-17  Nima Ghanavatian  <nghanavatian@blackberry.com>
> 
>         Clean up spellcheck state when changing focus.
>-- 
>1.7.10.4
>

Actions: View | Formatted Diff | Diff

Attachments on bug 114670: 198471 | 198474 | 198480 | 198481 | 198483 | 198487 | 198488 | 198490 | 198492 | 198495 | 198496 | 198497 | 198673 | 198680 | 198681 | 198682 | 198697 | 198702 | 198703 | 198704 | 198705