Attachment 188687 Details for Bug 109999 – Patch

[patch] Patch

bug-109999-20130215190933.patch (text/plain), 1.28 KB, created by Benjamin Poulain on 2013-02-15 19:13:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Poulain

Created: 2013-02-15 19:13:07 PST

Size: 1.28 KB

patch

obsolete

>Subversion Revision: 143051
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 4619e97cc6135d4db94b94094aec2aa69229442b..08b3678760198205959d5edea762be0167b1094c 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,16 @@
>+2013-02-15  Benjamin Poulain  <bpoulain@apple.com>
>+
>+        Remove Vector::dataSlot(), it has no implementation
>+        https://bugs.webkit.org/show_bug.cgi?id=109999
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        VectorBufferBase does not implement any function bufferSlot().
>+        The file only compiles because that part of the template is never
>+        instanciated.
>+
>+        * wtf/Vector.h:
>+
> 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
> 
>         Add CString operators for comparison with const char*
>diff --git a/Source/WTF/wtf/Vector.h b/Source/WTF/wtf/Vector.h
>index b76c61d01a909eb13fddf742b586fe818a676bf0..8f8ce89c514bd81c975ad2e07a3333e8e45249e5 100644
>--- a/Source/WTF/wtf/Vector.h
>+++ b/Source/WTF/wtf/Vector.h
>@@ -564,7 +564,6 @@ namespace WTF {
> 
>         T* data() { return m_buffer.buffer(); }
>         const T* data() const { return m_buffer.buffer(); }
>-        T** dataSlot() { return m_buffer.bufferSlot(); }
> 
>         iterator begin() { return data(); }
>         iterator end() { return begin() + m_size; }

Flags:

kling: review+
buildbot: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 109999: 188687